Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3137)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/sys_info.cc

Issue 699173002: UMA: Set Hardware model class on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/sys_info.h ('K') | « base/sys_info.h ('k') | base/sys_info_mac.cc » ('j') | base/sys_info_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/sys_info.cc
diff --git a/base/sys_info.cc b/base/sys_info.cc
index 0b3b317fc8bf2a92a72bcf2991af8da3470ac2b0..1e0bb88c874b9fa291fbf9127f9a9f9c779a8f58 100644
--- a/base/sys_info.cc
+++ b/base/sys_info.cc
@@ -44,6 +44,13 @@ bool SysInfo::IsLowEndDevice() {
}
#endif
+#if !defined(OS_MACOSX)
Mark Mentovai 2014/11/04 14:36:37 Why even bother implementing this for non-Mac? Not
jeremy 2014/11/05 05:38:06 Leaving this in per-asvitkine's comment.
+std::string SysInfo::HardwareModelName() {
+ NOTIMPLEMENTED() << "HardwareModelName() not supported.";
+ return "";
Alexei Svitkine (slow) 2014/11/04 16:22:12 Nit: std::string()
jeremy 2014/11/05 05:38:06 Done.
+}
+#endif
+
// static
int64 SysInfo::Uptime() {
// This code relies on an implementation detail of TimeTicks::Now() - that
« base/sys_info.h ('K') | « base/sys_info.h ('k') | base/sys_info_mac.cc » ('j') | base/sys_info_mac.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698