UMA: Set Hardware model class on Mac.

base/sys_info.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/sys_info.h"
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 26 matching lines @@
 static LazyInstance<
   internal::LazySysInfoValue<bool, DetectLowEndDevice> >::Leaky
   g_lazy_low_end_device = LAZY_INSTANCE_INITIALIZER;
 
 // static
 bool SysInfo::IsLowEndDevice() {
   return g_lazy_low_end_device.Get().value();
 }
 #endif
 
+#if !defined(OS_MACOSX)

[Mark Mentovai, 2014/11/04 14:36:37]

Why even bother implementing this for non-Mac? Nothing ever calls it. Better to
just wrap the declaration in the header in an #if defined(OS_MACOSX).

[jeremy, 2014/11/05 05:38:06]

Leaving this in per-asvitkine's comment.

+std::string SysInfo::HardwareModelName() {
+  NOTIMPLEMENTED() << "HardwareModelName() not supported.";
+  return "";

[Alexei Svitkine (slow), 2014/11/04 16:22:12]

Nit: std::string()

[jeremy, 2014/11/05 05:38:06]

Done.

+}
+#endif
+
 // static
 int64 SysInfo::Uptime() {
   // This code relies on an implementation detail of TimeTicks::Now() - that
   // its return value happens to coincide with the system uptime value in
   // microseconds, on Win/Mac/iOS/Linux/ChromeOS and Android.
   int64 uptime_in_microseconds = TimeTicks::Now().ToInternalValue();
   return uptime_in_microseconds / 1000;
 }
 
 }  // namespace base