Input type button in group role is not exposed correctly on Mac(blink)

Input type button in group role is not exposed correctly on Mac(blink)

According to latest editor's draft http://rawgit.com/w3c/aria/master/html-aam/html-aam.html
input type button with menu as parent should be exposed as below:

If the option's parent has a group role, then maps to AXMenuButton
If the option's parent has a menu role, then maps to AXMenuItem

AXRole: AXMenuItem
AXSubrole: <nil>
AXRoleDescription: 'menu item'

This patch would return MenuButtonRole, when button is child of GroupRole.

BUG=431773

[shreeramk, 2014-11-11 03:16:09]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[shreeramk, 2014-11-11 03:16:10]

Please review. 
Thanks!

[dmazzoni, 2014-11-11 06:38:27]

I don't understand the reasoning behind the spec here. It seems incomplete.

Lots of things have a role of "group" - that alone shouldn't make something into
a menu button. Do they mean when the parent role is "group" but an ancestor is
of role "menu"?

Another concern is that this change would affect all platforms, not just Mac.

[shreeramk, 2014-11-11 06:57:20]

On 2014/11/11 06:38:27, dmazzoni wrote:
> I don't understand the reasoning behind the spec here. It seems incomplete.
> 
> Lots of things have a role of "group" - that alone shouldn't make something
into
> a menu button. Do they mean when the parent role is "group" but an ancestor is
> of role "menu"?

Hmm... Correct lot of things can have role of "Group". 

After reading the spec, I thought for content like this,(But my changes is not
proper according to how I meant)

<div role="group">
<input type=button>
</div>

it has to be exposed with AXMenuButton role on MAC.

But I think, I misunderstood the spec, it says "If the option's parent has a
group role, then maps to AXMenuButton". That means, if the parent of input
type="button" is having group role, then it would be exposed with AXMenuButton
Role on MAC.

I am kind a confuse with this. :(

> Another concern is that this change would affect all platforms, not just Mac.

This change wouldn't effect on windows because ROLE_SYSTEM_MENUITEM would be
exposed on windows whether the parent is menu or an element with aria role
group.

[shreeramk, 2014-11-12 16:18:51]

@Dominic:
I was going through code and found this API remapAriaRoleDueToParent() and this
code snippet in it.

// An aria "menuitem" may map to MenuButton or MenuItem depending on its parent.
        if (role == MenuItemRole && parentAriaRole == GroupRole)
            return MenuButtonRole;

The spec says when aria role "menuitem" is a child of an element with aria role
"group" the it would be exposed as AXMenuButton role on MAC.

And similar spec is for input type button with parent having aria role as
"group". I think we should follow the same for input type button as well.

[dmazzoni, 2014-11-12 18:16:46]

On 2014/11/12 16:18:51, shreeramk wrote:
> @Dominic:
> I was going through code and found this API remapAriaRoleDueToParent() and
this
> code snippet in it.
> 
> // An aria "menuitem" may map to MenuButton or MenuItem depending on its
parent.
>         if (role == MenuItemRole && parentAriaRole == GroupRole)
>             return MenuButtonRole;
> 
> The spec says when aria role "menuitem" is a child of an element with aria
role
> "group" the it would be exposed as AXMenuButton role on MAC.
> 
> And similar spec is for input type button with parent having aria role as
> "group". I think we should follow the same for input type button as well.

I'm going to file a bug asking for clarification, because I still don't
understand the purpose of the spec.