Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: Source/core/accessibility/AXNodeObject.cpp

Issue 699083007: Input type button in group role is not exposed correctly on Mac(blink) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: updating correct condition Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/accessibility/AXRenderObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/accessibility/AXNodeObject.cpp
diff --git a/Source/core/accessibility/AXNodeObject.cpp b/Source/core/accessibility/AXNodeObject.cpp
index 1140082d95d1d0efe228b4ba3fd2eb7612863ddc..8cb88e486284a92c7d0d34c76e0bf41a8c8aee48 100644
--- a/Source/core/accessibility/AXNodeObject.cpp
+++ b/Source/core/accessibility/AXNodeObject.cpp
@@ -204,12 +204,14 @@ AccessibilityRole AXNodeObject::determineAccessibilityRole()
HTMLInputElement& input = toHTMLInputElement(*node());
const AtomicString& type = input.type();
if (type == InputTypeNames::button) {
- if ((node()->parentNode() && isHTMLMenuElement(node()->parentNode())) || (parentObject() && parentObject()->roleValue() == MenuRole))
+ if ((node()->parentNode() && isHTMLMenuElement(node()->parentNode())) || (parentObject() && parentObject()->ariaRoleAttribute() == MenuRole))
return MenuItemRole;
+ if (parentObject() && parentObject()->ariaRoleAttribute() == GroupRole)
+ return MenuButtonRole;
return buttonRoleType();
}
if (type == InputTypeNames::checkbox) {
- if ((node()->parentNode() && isHTMLMenuElement(node()->parentNode())) || (parentObject() && parentObject()->roleValue() == MenuRole))
+ if ((node()->parentNode() && isHTMLMenuElement(node()->parentNode())) || (parentObject() && parentObject()->ariaRoleAttribute() == MenuRole))
return MenuItemCheckBoxRole;
return CheckBoxRole;
}
@@ -221,7 +223,7 @@ AccessibilityRole AXNodeObject::determineAccessibilityRole()
|| type == InputTypeNames::week)
return DateTimeRole;
if (type == InputTypeNames::radio) {
- if ((node()->parentNode() && isHTMLMenuElement(node()->parentNode())) || (parentObject() && parentObject()->roleValue() == MenuRole))
+ if ((node()->parentNode() && isHTMLMenuElement(node()->parentNode())) || (parentObject() && parentObject()->ariaRoleAttribute() == MenuRole))
return MenuItemRadioRole;
return RadioButtonRole;
}
« no previous file with comments | « no previous file | Source/core/accessibility/AXRenderObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698