Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: Source/core/css/CSSRule.cpp

Issue 699043003: bindings: Makes CSSRule inherit from ScriptWrappable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSRule.h ('k') | Source/core/css/CSSRule.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSRule.cpp
diff --git a/Source/core/css/CSSRule.cpp b/Source/core/css/CSSRule.cpp
index 74c1e89620ac72104a29a052e21e27570108a995..426b7681d36f67a0fb6bc56bff35c6969257b92c 100644
--- a/Source/core/css/CSSRule.cpp
+++ b/Source/core/css/CSSRule.cpp
@@ -29,19 +29,7 @@
namespace blink {
-// VC++ 2013 doesn't support EBCO (Empty Base Class Optimization), and having
-// multiple empty base classes makes the size of CSSRule bloat (Note that both
-// of GarbageCollectedFinalized and ScriptWrappableBase are empty classes).
-// See the following article for details.
-// http://social.msdn.microsoft.com/forums/vstudio/en-US/504c6598-6076-4acf-96b6-e6acb475d302/vc-multiple-inheritance-empty-base-classes-bloats-object-size
-//
-// FIXME: Remove ScriptWrappableBase from the base class list once VC++'s issue
-// gets fixed.
-// Note that we're going to split CSSRule class into two classes; CSSOMRule
-// (assumed name) which derives ScriptWrappable and CSSRule (new one) which
-// doesn't derive ScriptWrappable or ScriptWrappableBase. Then, we can safely
-// remove ScriptWrappableBase from the base class list.
-struct SameSizeAsCSSRule : public RefCountedWillBeGarbageCollectedFinalized<SameSizeAsCSSRule>, public ScriptWrappableBase {
+struct SameSizeAsCSSRule : public RefCountedWillBeGarbageCollectedFinalized<SameSizeAsCSSRule>, public ScriptWrappable {
virtual ~SameSizeAsCSSRule();
unsigned char bitfields;
void* pointerUnion;
« no previous file with comments | « Source/core/css/CSSRule.h ('k') | Source/core/css/CSSRule.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698