| OLD | NEW |
| 1 /* | 1 /* |
| 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) | 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) |
| 3 * (C) 2002-2003 Dirk Mueller (mueller@kde.org) | 3 * (C) 2002-2003 Dirk Mueller (mueller@kde.org) |
| 4 * Copyright (C) 2002, 2005, 2006, 2007, 2012 Apple Inc. All rights reserved. | 4 * Copyright (C) 2002, 2005, 2006, 2007, 2012 Apple Inc. All rights reserved. |
| 5 * | 5 * |
| 6 * This library is free software; you can redistribute it and/or | 6 * This library is free software; you can redistribute it and/or |
| 7 * modify it under the terms of the GNU Library General Public | 7 * modify it under the terms of the GNU Library General Public |
| 8 * License as published by the Free Software Foundation; either | 8 * License as published by the Free Software Foundation; either |
| 9 * version 2 of the License, or (at your option) any later version. | 9 * version 2 of the License, or (at your option) any later version. |
| 10 * | 10 * |
| (...skipping 11 matching lines...) Expand all Loading... |
| 22 #include "config.h" | 22 #include "config.h" |
| 23 #include "core/css/CSSRule.h" | 23 #include "core/css/CSSRule.h" |
| 24 | 24 |
| 25 #include "core/css/CSSStyleSheet.h" | 25 #include "core/css/CSSStyleSheet.h" |
| 26 #include "core/css/StyleRule.h" | 26 #include "core/css/StyleRule.h" |
| 27 #include "core/css/StyleSheetContents.h" | 27 #include "core/css/StyleSheetContents.h" |
| 28 #include "platform/NotImplemented.h" | 28 #include "platform/NotImplemented.h" |
| 29 | 29 |
| 30 namespace blink { | 30 namespace blink { |
| 31 | 31 |
| 32 // VC++ 2013 doesn't support EBCO (Empty Base Class Optimization), and having | 32 struct SameSizeAsCSSRule : public RefCountedWillBeGarbageCollectedFinalized<Same
SizeAsCSSRule>, public ScriptWrappable { |
| 33 // multiple empty base classes makes the size of CSSRule bloat (Note that both | |
| 34 // of GarbageCollectedFinalized and ScriptWrappableBase are empty classes). | |
| 35 // See the following article for details. | |
| 36 // http://social.msdn.microsoft.com/forums/vstudio/en-US/504c6598-6076-4acf-96b6
-e6acb475d302/vc-multiple-inheritance-empty-base-classes-bloats-object-size | |
| 37 // | |
| 38 // FIXME: Remove ScriptWrappableBase from the base class list once VC++'s issue | |
| 39 // gets fixed. | |
| 40 // Note that we're going to split CSSRule class into two classes; CSSOMRule | |
| 41 // (assumed name) which derives ScriptWrappable and CSSRule (new one) which | |
| 42 // doesn't derive ScriptWrappable or ScriptWrappableBase. Then, we can safely | |
| 43 // remove ScriptWrappableBase from the base class list. | |
| 44 struct SameSizeAsCSSRule : public RefCountedWillBeGarbageCollectedFinalized<Same
SizeAsCSSRule>, public ScriptWrappableBase { | |
| 45 virtual ~SameSizeAsCSSRule(); | 33 virtual ~SameSizeAsCSSRule(); |
| 46 unsigned char bitfields; | 34 unsigned char bitfields; |
| 47 void* pointerUnion; | 35 void* pointerUnion; |
| 48 }; | 36 }; |
| 49 | 37 |
| 50 COMPILE_ASSERT(sizeof(CSSRule) == sizeof(SameSizeAsCSSRule), CSSRule_should_stay
_small); | 38 COMPILE_ASSERT(sizeof(CSSRule) == sizeof(SameSizeAsCSSRule), CSSRule_should_stay
_small); |
| 51 | 39 |
| 52 COMPILE_ASSERT(StyleRuleBase::Viewport == static_cast<StyleRuleBase::Type>(CSSRu
le::VIEWPORT_RULE), enums_should_match); | 40 COMPILE_ASSERT(StyleRuleBase::Viewport == static_cast<StyleRuleBase::Type>(CSSRu
le::VIEWPORT_RULE), enums_should_match); |
| 53 | 41 |
| 54 void CSSRule::setCSSText(const String&) | 42 void CSSRule::setCSSText(const String&) |
| (...skipping 14 matching lines...) Expand all Loading... |
| 69 // pre-oilpan world, where the parent link is mysteriously zeroed under | 57 // pre-oilpan world, where the parent link is mysteriously zeroed under |
| 70 // some circumstances. | 58 // some circumstances. |
| 71 if (m_parentIsRule) | 59 if (m_parentIsRule) |
| 72 visitor->trace(m_parentRule); | 60 visitor->trace(m_parentRule); |
| 73 else | 61 else |
| 74 visitor->trace(m_parentStyleSheet); | 62 visitor->trace(m_parentStyleSheet); |
| 75 #endif | 63 #endif |
| 76 } | 64 } |
| 77 | 65 |
| 78 } // namespace blink | 66 } // namespace blink |
| OLD | NEW |