Got rid of the internal copies of webview attributes.

Got rid of the internal copies of webview attributes.

Webview attributes are now only stored in one location (in the webview node), so that all the code needed to sync up the copies could be removed (and was).

Also reworked the behavior of the |allowtransparency| and |autosize| to be both consistent with each other and more intuitive in general (they are both treated like booleans now). I updated the tests to reflect this new behavior.

Committed: https://crrev.com/abb035a09b79c2e0b6d9fb87b47e823e2f8e0549
Cr-Commit-Position: refs/heads/master@{#302661}

[paulmeyer, 2014-11-03 22:26:32]

+fsamuel@

[paulmeyer, 2014-11-03 22:29:45]

paulmeyer@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2014-11-03 22:38:18]

LGTM but can we reuse the test code in extensions?

https://codereview.chromium.org/698973003/diff/1/extensions/renderer/resource...
File extensions/renderer/resources/guest_view/web_view.js (right):

https://codereview.chromium.org/698973003/diff/1/extensions/renderer/resource...
extensions/renderer/resources/guest_view/web_view.js:454: var result = {};
Is this necessary?

https://codereview.chromium.org/698973003/diff/1/extensions/renderer/resource...
File extensions/renderer/resources/guest_view/web_view_attributes.js (right):

https://codereview.chromium.org/698973003/diff/1/extensions/renderer/resource...
extensions/renderer/resources/guest_view/web_view_attributes.js:72: newValue;
It doesn't seem like you need both persistStorage and storagePartitionId.

[paulmeyer, 2014-11-03 22:58:19]

Addressed comments.

https://codereview.chromium.org/698973003/diff/1/extensions/renderer/resource...
File extensions/renderer/resources/guest_view/web_view.js (right):

https://codereview.chromium.org/698973003/diff/1/extensions/renderer/resource...
extensions/renderer/resources/guest_view/web_view.js:454: var result = {};
On 2014/11/03 22:38:18, Fady Samuel wrote:
> Is this necessary?

no

https://codereview.chromium.org/698973003/diff/1/extensions/renderer/resource...
File extensions/renderer/resources/guest_view/web_view_attributes.js (right):

https://codereview.chromium.org/698973003/diff/1/extensions/renderer/resource...
extensions/renderer/resources/guest_view/web_view_attributes.js:72: newValue;
On 2014/11/03 22:38:18, Fady Samuel wrote:
> It doesn't seem like you need both persistStorage and storagePartitionId. 

Done.

[paulmeyer, 2014-11-03 22:58:24]

The CQ bit was checked by paulmeyer@chromium.org

[commit-bot: I haz the power, 2014-11-03 23:00:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/698973003/20001

[paulmeyer, 2014-11-03 23:02:14]

The CQ bit was unchecked by paulmeyer@chromium.org

[Fady Samuel, 2014-11-03 23:14:53]

still lgtm

[paulmeyer, 2014-11-04 14:40:43]

The CQ bit was checked by paulmeyer@chromium.org

[commit-bot: I haz the power, 2014-11-04 14:41:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/698973003/60001

[commit-bot: I haz the power, 2014-11-04 14:47:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-04 14:47:30]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[paulmeyer, 2014-11-04 15:23:47]

The CQ bit was checked by paulmeyer@chromium.org

[commit-bot: I haz the power, 2014-11-04 15:25:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/698973003/60001

[commit-bot: I haz the power, 2014-11-04 16:27:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-04 16:27:17]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[paulmeyer, 2014-11-04 19:52:37]

The CQ bit was checked by paulmeyer@chromium.org

[commit-bot: I haz the power, 2014-11-04 19:54:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/698973003/80001

[commit-bot: I haz the power, 2014-11-04 21:01:54]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-11-04 21:02:24]

Patchset 5 (id:??) landed as
https://crrev.com/abb035a09b79c2e0b6d9fb87b47e823e2f8e0549
Cr-Commit-Position: refs/heads/master@{#302661}