extensions/browser/guest_view/web_view/web_view_apitest.cc - Issue 698973003: Got rid of the internal copies of webview attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_apitest.cc

Issue 698973003: Got rid of the internal copies of webview attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small fix. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/platform_apps/web_view/shim/main.js ('k') | extensions/renderer/resources/guest_view/web_view.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_apitest.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_apitest.cc b/extensions/browser/guest_view/web_view/web_view_apitest.cc

index 6f052ab409f26a614b96c899ba99f19b7e65c010..0502ecb78315d883eda06110577d7ecbe5de4d80 100644

--- a/extensions/browser/guest_view/web_view/web_view_apitest.cc

+++ b/extensions/browser/guest_view/web_view/web_view_apitest.cc

@@ -615,8 +615,8 @@ IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestOnEventProperty) {

RunTest("testOnEventProperties", "web_view/apitest");

}

-IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestPartitionRaisesException) {

- RunTest("testPartitionRaisesException", "web_view/apitest");

+IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestPartitionChangeAfterNavigation) {

+ RunTest("testPartitionChangeAfterNavigation", "web_view/apitest");

}

IN_PROC_BROWSER_TEST_F(WebViewAPITest,