Source/web/PluginPlaceholderImpl.cpp - Issue 698533003: Implement support for closing shadow DOM plugin placeholders.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/PluginPlaceholderImpl.cpp

Issue 698533003: Implement support for closing shadow DOM plugin placeholders. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: mkwst comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "config.h"	5 #include "config.h"

6 #include "web/PluginPlaceholderImpl.h"	6 #include "web/PluginPlaceholderImpl.h"

7	7

8 #include "core/dom/shadow/ShadowRoot.h"	8 #include "core/dom/shadow/ShadowRoot.h"

9 #include "core/html/HTMLPlugInElement.h"	9 #include "core/html/HTMLPlugInElement.h"

10 #include "core/html/shadow/PluginPlaceholderElement.h"	10 #include "core/html/shadow/PluginPlaceholderElement.h"

(...skipping 21 matching lines...) Expand all Loading...
32 {	32 {

33 m_placeholderElement->remove(ASSERT_NO_EXCEPTION);	33 m_placeholderElement->remove(ASSERT_NO_EXCEPTION);

34 update();	34 update();

35 container.removeChildren();	35 container.removeChildren();

36 container.appendChild(m_placeholderElement);	36 container.appendChild(m_placeholderElement);

37 }	37 }

38	38

39 void PluginPlaceholderImpl::update()	39 void PluginPlaceholderImpl::update()

40 {	40 {

41 m_placeholderElement->setMessage(m_webPluginPlaceholder->message());	41 m_placeholderElement->setMessage(m_webPluginPlaceholder->message());

	42 m_placeholderElement->setIsCloseable(m_webPluginPlaceholder->isCloseable());

42 }	43 }

43	44

44 } // namespace blink	45 } // namespace blink

OLD	NEW