Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 698493002: Always enable layer hoisting in Skia (Closed)

Created:
6 years, 1 month ago by robertphillips
Modified:
6 years, 1 month ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Always enable layer hoisting in Skia This will prevent bit rot of the layer hoisting code and position us better for turning this on in Chromium. Committed: https://skia.googlesource.com/skia/+/66cad7669be6c47768d084090a3d498014dfc847

Patch Set 1 #

Patch Set 2 : update to ToT #

Patch Set 3 : Fix merge issue #

Patch Set 4 : Fix no-gpu build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkMultiPictureDraw.cpp View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
robertphillips
6 years, 1 month ago (2014-10-31 12:46:03 UTC) #2
robertphillips
ping
6 years, 1 month ago (2014-11-03 14:04:08 UTC) #4
bsalomon
lgtm
6 years, 1 month ago (2014-11-03 14:22:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698493002/1
6 years, 1 month ago (2014-11-03 14:31:50 UTC) #7
commit-bot: I haz the power
Failed to apply patch for expectations/gm/ignored-tests.txt: While running git apply --index -3 -p1; error: patch ...
6 years, 1 month ago (2014-11-03 14:31:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698493002/40001
6 years, 1 month ago (2014-11-03 14:51:01 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/406) Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/503)
6 years, 1 month ago (2014-11-03 14:52:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698493002/60001
6 years, 1 month ago (2014-11-03 15:11:21 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 66cad7669be6c47768d084090a3d498014dfc847
6 years, 1 month ago (2014-11-03 15:19:34 UTC) #16
mtklein
6 years, 1 month ago (2014-11-03 22:33:46 UTC) #17
Message was sent while issue was closed.
On 2014/11/03 15:19:34, I haz the power (commit-bot) wrote:
> Committed patchset #4 (id:60001) as 66cad7669be6c47768d084090a3d498014dfc847

Valgrind sez: memory leak!

http://chromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu12-ShuttleA...

Powered by Google App Engine
This is Rietveld 408576698