content/browser/renderer_host/render_widget_host_view_android.h - Issue 698253004: Reland: Implement Aura side of unified touch text selection for contents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 698253004: Reland: Implement Aura side of unified touch text selection for contents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test failures on Mac Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/ui_touch_selection_helper.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.cc » ('j') | content/browser/renderer_host/render_widget_host_view_aura.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.h

diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h

index 3aec51e3444a5a9cf91ddc78e02115c7578516aa..7f6816ddd3d428e8b01a43be961b57d7af235236 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.h

+++ b/content/browser/renderer_host/render_widget_host_view_android.h

@@ -220,6 +220,8 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid

const gfx::PointF& extent) override;

void OnSelectionEvent(ui::SelectionEventType event) override;

scoped_ptr<ui::TouchHandleDrawable> CreateDrawable() override;

+ void OnScrollStarted() override;

+ void OnScrollCompleted() override;

sadrul 2015/04/29 19:55:03 optional: Would it make sense to call these OnSele

mohsen 2015/04/30 18:29:34 I agree, that makes more sense. Done.

// Non-virtual methods

void SetContentViewCore(ContentViewCoreImpl* content_view_core);