Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1542)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 698253004: Reland: Implement Aura side of unified touch text selection for contents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test failures on Mac Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 8bfa8b2fb88b2f835df484e7a14d67da0943b3c8..8164046a85e0f31a16410b92993b6442ea904e63 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -51,6 +51,7 @@
#include "content/browser/renderer_host/dip_util.h"
#include "content/browser/renderer_host/frame_metadata_util.h"
#include "content/browser/renderer_host/input/synthetic_gesture_target_android.h"
+#include "content/browser/renderer_host/input/ui_touch_selection_helper.h"
#include "content/browser/renderer_host/input/web_input_event_builders_android.h"
#include "content/browser/renderer_host/input/web_input_event_util.h"
#include "content/browser/renderer_host/render_process_host_impl.h"
@@ -290,32 +291,6 @@ ui::GestureProvider::Config CreateGestureProviderConfig() {
return config;
}
-ui::SelectionBound::Type ConvertSelectionBoundType(
- cc::SelectionBoundType type) {
- switch (type) {
- case cc::SELECTION_BOUND_LEFT:
- return ui::SelectionBound::LEFT;
- case cc::SELECTION_BOUND_RIGHT:
- return ui::SelectionBound::RIGHT;
- case cc::SELECTION_BOUND_CENTER:
- return ui::SelectionBound::CENTER;
- case cc::SELECTION_BOUND_EMPTY:
- return ui::SelectionBound::EMPTY;
- }
- NOTREACHED() << "Unknown selection bound type";
- return ui::SelectionBound::EMPTY;
-}
-
-ui::SelectionBound ConvertSelectionBound(
- const cc::ViewportSelectionBound& bound) {
- ui::SelectionBound ui_bound;
- ui_bound.set_type(ConvertSelectionBoundType(bound.type));
- ui_bound.set_visible(bound.visible);
- if (ui_bound.type() != ui::SelectionBound::EMPTY)
- ui_bound.SetEdge(bound.edge_top, bound.edge_bottom);
- return ui_bound;
-}
-
gfx::RectF GetSelectionRect(const ui::TouchSelectionController& controller) {
gfx::RectF rect = controller.GetRectBetweenBounds();
if (rect.IsEmpty())
@@ -1341,6 +1316,12 @@ RenderWidgetHostViewAndroid::CreateDrawable() {
content_view_core_->GetContext().obj()));
}
+void RenderWidgetHostViewAndroid::OnScrollStarted() {
+}
+
+void RenderWidgetHostViewAndroid::OnScrollCompleted() {
+}
+
void RenderWidgetHostViewAndroid::SynchronousCopyContents(
const gfx::Rect& src_subrect_in_pixel,
const gfx::Size& dst_size_in_pixel,
@@ -1397,7 +1378,7 @@ void RenderWidgetHostViewAndroid::OnFrameMetadataUpdated(
frame_metadata.selection.is_editable);
selection_controller_->OnSelectionEmpty(
frame_metadata.selection.is_empty_text_form_control);
- selection_controller_->OnSelectionBoundsChanged(
+ selection_controller_->OnSelectionBoundsUpdated(
ConvertSelectionBound(frame_metadata.selection.start),
ConvertSelectionBound(frame_metadata.selection.end));
}
@@ -1787,7 +1768,7 @@ void RenderWidgetHostViewAndroid::OnShowingPastePopup(
selection_controller_->HideAndDisallowShowingAutomatically();
selection_controller_->OnSelectionEditable(true);
selection_controller_->OnSelectionEmpty(true);
- selection_controller_->OnSelectionBoundsChanged(insertion_bound,
+ selection_controller_->OnSelectionBoundsUpdated(insertion_bound,
insertion_bound);
selection_controller_->AllowShowingFromCurrentSelection();
}

Powered by Google App Engine
This is Rietveld 408576698