Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 69813008: Web Animations CSS: Renamed tests to be less confusing (Closed)

Created:
7 years, 1 month ago by shans
Modified:
7 years, 1 month ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Renamed tests to be less confusing BUG=232278 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162185

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -165 lines) Patch
M Source/core/animation/AnimatableColorTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/AnimatableDoubleTest.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/AnimatableLength.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableLengthTest.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M Source/core/animation/AnimatableNeutralTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/AnimatableStrokeDasharrayListTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableUnknownTest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/AnimatableValueTestHelperTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/AnimationClockTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/CompositorAnimationsImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CompositorAnimationsTest.cpp View 1 2 34 chunks +41 lines, -41 lines 0 comments Download
M Source/core/animation/CompositorAnimationsTestHelper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/CompositorAnimationsTimingFunctionReverserTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/DocumentTimeline.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/DocumentTimelineTest.cpp View 8 chunks +12 lines, -12 lines 0 comments Download
M Source/core/animation/KeyframeAnimationEffectTest.cpp View 20 chunks +21 lines, -21 lines 0 comments Download
M Source/core/animation/PlayerTest.cpp View 1 21 chunks +21 lines, -21 lines 0 comments Download
M Source/core/animation/TimedItemCalculationsTest.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/TimedItemTest.cpp View 23 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
shans
7 years, 1 month ago (2013-11-18 02:34:40 UTC) #1
dstockwell
lgtm
7 years, 1 month ago (2013-11-18 02:54:27 UTC) #2
Mike Lawther (Google)
Test renames only - lgtm.
7 years, 1 month ago (2013-11-18 02:56:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shans@chromium.org/69813008/1
7 years, 1 month ago (2013-11-18 03:10:40 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=12850
7 years, 1 month ago (2013-11-18 04:19:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shans@chromium.org/69813008/30003
7 years, 1 month ago (2013-11-18 04:46:53 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, wtf_unittests ...
7 years, 1 month ago (2013-11-18 05:31:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shans@chromium.org/69813008/390001
7 years, 1 month ago (2013-11-18 08:46:30 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 09:54:29 UTC) #9
Message was sent while issue was closed. 
Change committed as 162185

Powered by Google App Engine
This is Rietveld 408576698