Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7520)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc

Issue 69813005: Fix crash in WebContentsViewAura::WindowObserver that happens when switching tabs. The exact repro … (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_view_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
===================================================================
--- chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc (revision 235277)
+++ chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc (working copy)
@@ -141,6 +141,22 @@
region_before.bottom == region_after.bottom;
ASSERT_FALSE(rects_equal);
}
+
+IN_PROC_BROWSER_TEST_F(PrintPreviewTest, NoCrashOnCloseWithOtherTabs) {
+ // Now print preview.
+ Print();
+
+ ui_test_utils::NavigateToURLWithDisposition(
+ browser(), GURL("about:blank"), NEW_FOREGROUND_TAB,
+ ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
+
+ browser()->tab_strip_model()->ActivateTabAt(0, true);
+
+ // Navigate main tab to hide print preview.
+ ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));
+
+ browser()->tab_strip_model()->ActivateTabAt(1, true);
+}
#endif
} // namespace
« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_view_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698