Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc

Issue 69813005: Fix crash in WebContentsViewAura::WindowObserver that happens when switching tabs. The exact repro … (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_view_aura.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/prefs/pref_service.h" 6 #include "base/prefs/pref_service.h"
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/app/chrome_command_ids.h" 8 #include "chrome/app/chrome_command_ids.h"
9 #include "chrome/browser/content_settings/host_content_settings_map.h" 9 #include "chrome/browser/content_settings/host_content_settings_map.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 } 134 }
135 135
136 ASSERT_EQ(result, SIMPLEREGION); 136 ASSERT_EQ(result, SIMPLEREGION);
137 bool rects_equal = 137 bool rects_equal =
138 region_before.left == region_after.left && 138 region_before.left == region_after.left &&
139 region_before.top == region_after.top && 139 region_before.top == region_after.top &&
140 region_before.right == region_after.right && 140 region_before.right == region_after.right &&
141 region_before.bottom == region_after.bottom; 141 region_before.bottom == region_after.bottom;
142 ASSERT_FALSE(rects_equal); 142 ASSERT_FALSE(rects_equal);
143 } 143 }
144
145 IN_PROC_BROWSER_TEST_F(PrintPreviewTest, NoCrashOnCloseWithOtherTabs) {
146 // Now print preview.
147 Print();
148
149 ui_test_utils::NavigateToURLWithDisposition(
150 browser(), GURL("about:blank"), NEW_FOREGROUND_TAB,
151 ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
152
153 browser()->tab_strip_model()->ActivateTabAt(0, true);
154
155 // Navigate main tab to hide print preview.
156 ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));
157
158 browser()->tab_strip_model()->ActivateTabAt(1, true);
159 }
144 #endif 160 #endif
145 161
146 } // namespace 162 } // namespace
OLDNEW
« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_view_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698