Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Issue 698073005: Classes: Fix issue with default constructor crash (Closed)

Created:
6 years, 1 month ago by arv (Not doing code reviews)
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Classes: Fix issue with default constructor crash This partially implements calling super in the default constructor. BUG=v8:3661, v8:3672 LOG=Y R=dslomov

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix context issue by using EmitNewClosure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -44 lines) Patch
M src/bootstrapper.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M src/contexts.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/full-codegen.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M src/harmony-classes.js View 1 chunk +9 lines, -0 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 2 chunks +30 lines, -33 lines 0 comments Download
M test/mjsunit/harmony/classes.js View 2 chunks +41 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
arv (Not doing code reviews)
I think this one turned out better. https://codereview.chromium.org/698073005/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (left): https://codereview.chromium.org/698073005/diff/1/src/bootstrapper.cc#oldcode1575 src/bootstrapper.cc:1575: if (FLAG_harmony_proxies) ...
6 years, 1 month ago (2014-11-04 20:30:52 UTC) #1
Dmitry Lomov (no reviews)
(Note that dslomov@gmail.com is also me, but not at work) https://codereview.chromium.org/698073005/diff/1/src/runtime/runtime-classes.cc File src/runtime/runtime-classes.cc (right): https://codereview.chromium.org/698073005/diff/1/src/runtime/runtime-classes.cc#newcode112 ...
6 years, 1 month ago (2014-11-04 20:52:39 UTC) #3
arv (Not doing code reviews)
6 years, 1 month ago (2014-11-04 21:15:15 UTC) #4
Fix context issue by using EmitNewClosure

Powered by Google App Engine
This is Rietveld 408576698