src/full-codegen.cc - Issue 698073005: Classes: Fix issue with default constructor crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen.cc

Issue 698073005: Classes: Fix issue with default constructor crash (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix context issue by using EmitNewClosure Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen.cc

diff --git a/src/full-codegen.cc b/src/full-codegen.cc

index 58e5e978abf2dd7b73363378ccef7d1d4e9780f6..2bea70b0edee92d7084199c6bf33fa3dc2cbbdb8 100644

--- a/src/full-codegen.cc

+++ b/src/full-codegen.cc

@@ -1578,7 +1578,12 @@ void FullCodeGenerator::VisitClassLiteral(ClassLiteral* lit) {

if (lit->constructor() != NULL) {

VisitForStackValue(lit->constructor());

} else {

- __ Push(isolate()->factory()->undefined_value());

+ Handle<JSFunction> default_constructor =

+ lit->extends() == NULL ? isolate()->default_constructor_no_super()

+ : isolate()->default_constructor();

+ Handle<SharedFunctionInfo> shared(default_constructor->shared());

+ EmitNewClosure(shared, false);

+ __ Push(result_register());

}

__ Push(script());

« no previous file with comments | « src/contexts.h ('k') | src/harmony-classes.js » ('j') | no next file with comments »