Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 698043003: TransitionArray::Search() now returns insertion index if the entry was not found. (Closed)

Created:
6 years, 1 month ago by Igor Sheludko
Modified:
6 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

TransitionArray::Search() now returns insertion index if the entry was not found. This is a prerequisite for https://codereview.chromium.org/661133002/. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -52 lines) Patch
M src/objects.h View 1 chunk +3 lines, -6 lines 0 comments Download
M src/objects-inl.h View 5 chunks +34 lines, -13 lines 0 comments Download
M src/transitions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/transitions.cc View 4 chunks +32 lines, -30 lines 0 comments Download
M src/transitions-inl.h View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Igor Sheludko
PTAL
6 years, 1 month ago (2014-11-03 18:53:57 UTC) #2
Toon Verwaest
lgtm
6 years, 1 month ago (2014-11-04 09:18:43 UTC) #3
Igor Sheludko
6 years, 1 month ago (2014-11-04 09:29:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25099 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698