Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 697893003: Oilpan: avoid invoking some no-op finalizers. (Closed)

Created:
6 years, 1 month ago by sof
Modified:
6 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, kenneth.christiansen, Yoav Weiss, shans, rjwright, dstockwell, blink-reviews-animation_chromium.org, blink-reviews-css, sof, eae+blinkwatch, ed+blinkwatch_opera.com, Timothy Loh, Mike Lawther (Google), blink-reviews-dom_chromium.org, dglazkov+blink, Steve Block, apavlov+blink_chromium.org, darktears, Eric Willigers, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: avoid invoking some no-op finalizers. Derive from GarbageCollected<> instead whenever possible. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185218

Patch Set 1 #

Patch Set 2 : compile fix #

Total comments: 2

Patch Set 3 : Remove Finalized<> for StyleSheetList #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -35 lines) Patch
M Source/core/css/MediaList.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/MediaList.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/css/MediaQueryListListener.h View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/css/MediaQueryListListener.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/css/StyleSheetList.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/StyleSheetList.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/dom/MutationObserverInterestGroup.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Range.h View 1 chunk +9 lines, -1 line 0 comments Download
M Source/core/dom/Range.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/dom/ScriptedAnimationController.h View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/dom/ScriptedAnimationController.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/dom/StyleSheetCollection.h View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/dom/StyleSheetCollection.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
Please take a look.
6 years, 1 month ago (2014-11-12 14:11:51 UTC) #2
haraken
LGTM https://codereview.chromium.org/697893003/diff/20001/Source/core/css/StyleSheetList.h File Source/core/css/StyleSheetList.h (right): https://codereview.chromium.org/697893003/diff/20001/Source/core/css/StyleSheetList.h#newcode37 Source/core/css/StyleSheetList.h:37: class StyleSheetList final : public RefCountedWillBeGarbageCollectedFinalized<StyleSheetList>, public ScriptWrappable ...
6 years, 1 month ago (2014-11-12 14:39:01 UTC) #4
sof
https://codereview.chromium.org/697893003/diff/20001/Source/core/css/StyleSheetList.h File Source/core/css/StyleSheetList.h (right): https://codereview.chromium.org/697893003/diff/20001/Source/core/css/StyleSheetList.h#newcode37 Source/core/css/StyleSheetList.h:37: class StyleSheetList final : public RefCountedWillBeGarbageCollectedFinalized<StyleSheetList>, public ScriptWrappable { ...
6 years, 1 month ago (2014-11-12 14:48:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697893003/40001
6 years, 1 month ago (2014-11-12 16:42:02 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 16:44:23 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 185218

Powered by Google App Engine
This is Rietveld 408576698