Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: Source/core/css/MediaList.h

Issue 697893003: Oilpan: avoid invoking some no-op finalizers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove Finalized<> for StyleSheetList Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/css/MediaList.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2006, 2008, 2009, 2010, 2012 Apple Inc. All rights reserv ed. 3 * Copyright (C) 2004, 2006, 2008, 2009, 2010, 2012 Apple Inc. All rights reserv ed.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 63
64 void trace(Visitor*); 64 void trace(Visitor*);
65 65
66 private: 66 private:
67 MediaQuerySet(); 67 MediaQuerySet();
68 MediaQuerySet(const MediaQuerySet&); 68 MediaQuerySet(const MediaQuerySet&);
69 69
70 WillBeHeapVector<OwnPtrWillBeMember<MediaQuery> > m_queries; 70 WillBeHeapVector<OwnPtrWillBeMember<MediaQuery> > m_queries;
71 }; 71 };
72 72
73 class MediaList : public RefCountedWillBeGarbageCollectedFinalized<MediaList>, p ublic ScriptWrappable { 73 class MediaList final : public RefCountedWillBeGarbageCollected<MediaList>, publ ic ScriptWrappable {
74 DEFINE_WRAPPERTYPEINFO(); 74 DEFINE_WRAPPERTYPEINFO();
75 DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(MediaList);
75 public: 76 public:
76 static PassRefPtrWillBeRawPtr<MediaList> create(MediaQuerySet* mediaQueries, CSSStyleSheet* parentSheet) 77 static PassRefPtrWillBeRawPtr<MediaList> create(MediaQuerySet* mediaQueries, CSSStyleSheet* parentSheet)
77 { 78 {
78 return adoptRefWillBeNoop(new MediaList(mediaQueries, parentSheet)); 79 return adoptRefWillBeNoop(new MediaList(mediaQueries, parentSheet));
79 } 80 }
81
80 static PassRefPtrWillBeRawPtr<MediaList> create(MediaQuerySet* mediaQueries, CSSRule* parentRule) 82 static PassRefPtrWillBeRawPtr<MediaList> create(MediaQuerySet* mediaQueries, CSSRule* parentRule)
81 { 83 {
82 return adoptRefWillBeNoop(new MediaList(mediaQueries, parentRule)); 84 return adoptRefWillBeNoop(new MediaList(mediaQueries, parentRule));
83 } 85 }
84 86
85 ~MediaList();
86
87 unsigned length() const { return m_mediaQueries->queryVector().size(); } 87 unsigned length() const { return m_mediaQueries->queryVector().size(); }
88 String item(unsigned index) const; 88 String item(unsigned index) const;
89 void deleteMedium(const String& oldMedium, ExceptionState&); 89 void deleteMedium(const String& oldMedium, ExceptionState&);
90 void appendMedium(const String& newMedium, ExceptionState&); 90 void appendMedium(const String& newMedium, ExceptionState&);
91 91
92 String mediaText() const { return m_mediaQueries->mediaText(); } 92 String mediaText() const { return m_mediaQueries->mediaText(); }
93 void setMediaText(const String&); 93 void setMediaText(const String&);
94 94
95 // Not part of CSSOM. 95 // Not part of CSSOM.
96 CSSRule* parentRule() const { return m_parentRule; } 96 CSSRule* parentRule() const { return m_parentRule; }
(...skipping 20 matching lines...) Expand all
117 // Cleared in the ~CSSMediaRule and ~CSSImportRule destructors when oilpan i s not enabled. 117 // Cleared in the ~CSSMediaRule and ~CSSImportRule destructors when oilpan i s not enabled.
118 RawPtrWillBeMember<CSSRule> m_parentRule; 118 RawPtrWillBeMember<CSSRule> m_parentRule;
119 }; 119 };
120 120
121 // Adds message to inspector console whenever dpi or dpcm values are used for "s creen" media. 121 // Adds message to inspector console whenever dpi or dpcm values are used for "s creen" media.
122 void reportMediaQueryWarningIfNeeded(Document*, const MediaQuerySet*); 122 void reportMediaQueryWarningIfNeeded(Document*, const MediaQuerySet*);
123 123
124 } // namespace blink 124 } // namespace blink
125 125
126 #endif 126 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/core/css/MediaList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698