Script streaming: Add more Finch experiments for streaming policies.

Script streaming: Add more Finch experiments for streaming policies.

The Blink side already handles these policies; this CL is just plugging them
into Finch.

BUG=

Committed: https://crrev.com/e1c3b8bf8e8902149e8016d473bb172f027633bc
Cr-Commit-Position: refs/heads/master@{#302422}

[marja, 2014-10-31 13:41:33]

marja@chromium.org changed reviewers:
+ mkwst@chromium.org

[marja, 2014-10-31 13:41:34]

mkwst@, pls review this too (when you're back from ooo).

[Mike West, 2014-10-31 14:42:43]

IPC LGTM. However, it's not clear to me that this is doing what you want to be
doing with regard to the command line switch. See comment inline.

(You'll need a content/ OWNER regardless)

https://codereview.chromium.org/697673002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_view_host_impl.cc (right):

https://codereview.chromium.org/697673002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host_impl.cc:481:
prefs.v8_script_streaming_enabled = true;
This means that you're going to override the command line switch; is that really
what you want to be doing?

[marja, 2014-10-31 14:47:49]

thx for review

https://codereview.chromium.org/697673002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_view_host_impl.cc (right):

https://codereview.chromium.org/697673002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host_impl.cc:481:
prefs.v8_script_streaming_enabled = true;
On 2014/10/31 14:42:43, Mike West (OOO until 3rd) wrote:
> This means that you're going to override the command line switch; is that
really
> what you want to be doing?

Yes. People should get this enabled if 1) they got it enabled via Finch *or* 2)
they pass the switch.

See the previous code which did exactly that. Now it's just more complex since
there are several Finch options which will get this enabled.

[marja, 2014-11-03 08:46:33]

The CQ bit was checked by marja@chromium.org

[marja, 2014-11-03 08:46:56]

The CQ bit was unchecked by marja@chromium.org

[marja, 2014-11-03 08:47:22]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2014-11-03 08:48:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/697673002/1

[commit-bot: I haz the power, 2014-11-03 08:51:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-03 08:51:28]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[marja, 2014-11-03 08:58:32]

marja@chromium.org changed reviewers:
+ jochen@chromium.org

[marja, 2014-11-03 08:58:32]

ahh, more owners needed. Opportunistically adding jochen@ (are you online?)

[Mike West, 2014-11-03 08:59:43]

On 2014/11/03 08:58:32, marja wrote:
> ahh, more owners needed. Opportunistically adding jochen@ (are you online?)

(I did mention that you'd need a content/ OWNER. :) )

[marja, 2014-11-03 09:00:38]

On 2014/11/03 08:59:43, Mike West wrote:
> On 2014/11/03 08:58:32, marja wrote:
> > ahh, more owners needed. Opportunistically adding jochen@ (are you online?)
> 
> (I did mention that you'd need a content/ OWNER. :) )

Yes, you did, but I managed to miss it somehow.

[jochen (gone - plz use gerrit), 2014-11-03 09:09:29]

lgtm

https://codereview.chromium.org/697673002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_view_host_impl.cc (right):

https://codereview.chromium.org/697673002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host_impl.cc:483: }
else if {

[marja, 2014-11-03 09:13:33]

thx

https://codereview.chromium.org/697673002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_view_host_impl.cc (right):

https://codereview.chromium.org/697673002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host_impl.cc:483: }
On 2014/11/03 09:09:29, jochen (OOO) wrote:
> else if {

Done.

[marja, 2014-11-03 09:13:36]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2014-11-03 09:14:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/697673002/20001

[commit-bot: I haz the power, 2014-11-03 09:20:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-03 09:20:29]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[marja, 2014-11-03 09:22:03]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2014-11-03 09:22:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/697673002/40001

[commit-bot: I haz the power, 2014-11-03 09:43:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-03 09:43:29]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[marja, 2014-11-03 09:55:31]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2014-11-03 09:55:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/697673002/60001

[commit-bot: I haz the power, 2014-11-03 11:29:12]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-11-03 11:29:48]

Patchset 4 (id:??) landed as
https://crrev.com/e1c3b8bf8e8902149e8016d473bb172f027633bc
Cr-Commit-Position: refs/heads/master@{#302422}