Script streaming: Add more Finch experiments for streaming policies.

content/browser/renderer_host/render_view_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_view_host_impl.h"
 
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 455 matching lines @@
         command_line.GetSwitchValueASCII(switches::kV8CacheOptions);
     if (v8_cache_options == "parse") {
       prefs.v8_cache_options = V8_CACHE_OPTIONS_PARSE;
     } else if (v8_cache_options == "code") {
       prefs.v8_cache_options = V8_CACHE_OPTIONS_CODE;
     } else {
       prefs.v8_cache_options = V8_CACHE_OPTIONS_OFF;
     }
   }
 
+  std::string streaming_experiment_group =
+      base::FieldTrialList::FindFullName("V8ScriptStreaming");
   prefs.v8_script_streaming_enabled =
-      command_line.HasSwitch(switches::kEnableV8ScriptStreaming) ||
-      base::FieldTrialList::FindFullName("V8ScriptStreaming") == "Enabled";
+      command_line.HasSwitch(switches::kEnableV8ScriptStreaming);
+  if (streaming_experiment_group == "Enabled") {
+    prefs.v8_script_streaming_enabled = true;

[Mike West, 2014/10/31 14:42:43]

This means that you're going to override the command line switch; is that really
what you want to be doing?

[marja, 2014/10/31 14:47:48]

Yes. People should get this enabled if 1) they got it enabled via Finch *or* 2)
they pass the switch.

See the previous code which did exactly that. Now it's just more complex since
there are several Finch options which will get this enabled.

+    prefs.v8_script_streaming_mode = V8_SCRIPT_STREAMING_MODE_ALL;
+  }

[jochen (gone - plz use gerrit), 2014/11/03 09:09:29]

else if {

[marja, 2014/11/03 09:13:33]

Done.

+  if (streaming_experiment_group == "OnlyAsyncAndDefer") {
+    prefs.v8_script_streaming_enabled = true;
+    prefs.v8_script_streaming_mode =
+        V8_SCRIPT_STREAMING_MODE_ONLY_ASYNC_AND_DEFER;
+  }
+  if (streaming_experiment_group == "AllPlusBlockParserBlocking") {
+    prefs.v8_script_streaming_enabled = true;
+    prefs.v8_script_streaming_mode =
+        V8_SCRIPT_STREAMING_MODE_ALL_PLUS_BLOCK_PARSER_BLOCKING;
+  }
 
   GetContentClient()->browser()->OverrideWebkitPrefs(this, url, &prefs);
   return prefs;
 }
 
 void RenderViewHostImpl::SuppressDialogsUntilSwapOut() {
   Send(new ViewMsg_SuppressDialogsUntilSwapOut(GetRoutingID()));
 }
 
 void RenderViewHostImpl::ClosePage() {
@@ skipping 937 matching lines @@
   FrameTree* frame_tree = delegate_->GetFrameTree();
 
   frame_tree->ResetForMainFrameSwap();
 }
 
 void RenderViewHostImpl::SelectWordAroundCaret() {
   Send(new ViewMsg_SelectWordAroundCaret(GetRoutingID()));
 }
 
 }  // namespace content