Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: LayoutTests/fast/css-grid-layout/float-not-protruding-into-next-grid-item.html

Issue 697653004: [CSS Grid Layout] Grid items must set a new formatting context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Applied suggested changes. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css-grid-layout/float-not-protruding-into-next-grid-item.html
diff --git a/LayoutTests/fast/css-grid-layout/float-not-protruding-into-next-grid-item.html b/LayoutTests/fast/css-grid-layout/float-not-protruding-into-next-grid-item.html
new file mode 100644
index 0000000000000000000000000000000000000000..e1256b5c11f0ae5cdaa7421659c8d7651b345c76
--- /dev/null
+++ b/LayoutTests/fast/css-grid-layout/float-not-protruding-into-next-grid-item.html
@@ -0,0 +1,38 @@
+<!DOCTYPE html>
+<html>
+<head>
+<link href="resources/grid.css" rel="stylesheet">
+<style>
+.grid {
+ grid-auto-columns: minmax(50px, max-content);
+ grid-auto-rows: minmax(50px, max-content);
+ width: -webkit-fit-content;
+}
+
+.floatChild {
+ float: left;
+ clear: both;
+}
+
+</style>
+</style>
+</head>
+
+<body>
+
+<div>This test checks that grid item sets a new formatting context for its content, preventing any 'float' protruding content on the adjoining grid item.</div>
Manuel Rego 2014/11/12 14:11:53 This is ok as description but I think you're missi
jfernandez 2014/11/12 14:23:39 Done.
+
+<div class="grid">
+ <div class="firstRowFirstColumn">
+ <div class="floatChild">Float1</div>
+ <div class="floatChild">Float2</div>
+ <div class="floatChild">Float3</div>
+ <div class="floatChild">Float4</div>
+ </div>
+ <div class="firstRowSecondColumn"></div>
+ <div class="secondRowFirstColumn"></div>
+ <div class="secondRowSecondColumn"></div>
+</div>
+
+</body>
+</html>

Powered by Google App Engine
This is Rietveld 408576698