LayoutTests/fast/css-grid-layout/float-not-protruding-into-next-grid-item.html - Issue 697653004: [CSS Grid Layout] Grid items must set a new formatting context.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/float-not-protruding-into-next-grid-item.html

Issue 697653004: [CSS Grid Layout] Grid items must set a new formatting context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Applied suggested changes. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/float-not-protruding-into-next-grid-item-expected.html » ('j') | LayoutTests/fast/css-grid-layout/float-not-protruding-into-next-grid-item-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <link href="resources/grid.css" rel="stylesheet">

	5 <style>

	6 .grid {

	7 grid-auto-columns: minmax(50px, max-content);

	8 grid-auto-rows: minmax(50px, max-content);

	9 width: -webkit-fit-content;

	10 }

	11

	12 .floatChild {

	13 float: left;

	14 clear: both;

	15 }

	16

	17 </style>

	18 </style>

	19 </head>

	20

	21 <body>

	22

	23 <div>This test checks that grid item sets a new formatting context for its conte nt, preventing any 'float' protruding content on the adjoining grid item.</div>
	Manuel Rego 2014/11/12 14:11:53 This is ok as description but I think you're missi This is ok as description but I think you're missing the explanation of the expected output as Julien said. For example: Float text doesn't enter in the second row. jfernandez 2014/11/12 14:23:39 Done. Show quoted text On 2014/11/12 14:11:53, Manuel Rego wrote: > This is ok as description but I think you're missing the explanation > of the expected output as Julien said. > For example: Float text doesn't enter in the second row. Done.
	24

	25 <div class="grid">

	26 <div class="firstRowFirstColumn">

	27 <div class="floatChild">Float1</div>

	28 <div class="floatChild">Float2</div>

	29 <div class="floatChild">Float3</div>

	30 <div class="floatChild">Float4</div>

	31 </div>

	32 <div class="firstRowSecondColumn"></div>

	33 <div class="secondRowFirstColumn"></div>

	34 <div class="secondRowSecondColumn"></div>

	35 </div>

	36

	37 </body>

	38 </html>

OLD	NEW