Issue 6976025: Simplify the Scope API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6976025: Simplify the Scope API. (Closed)

Created:
9 years, 7 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Simplify the Scope API. Eliminate the LocalType enum in favor of a pair of functions, one for var and const declarations and one for parameters. Move the responsibility for adding a parameter variable to the Scope's internal data structure into the Scope and out of the parser. R=sgjesse@chromium.org BUG= TEST=

Patch Set 1 #

Patch Set 2 : Clarify comment. #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -36 lines)			Patch
M	src/parser.cc	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	src/scopes.h	View	1	4 chunks	+7 lines, -15 lines	0 comments	Download
M	src/scopes.cc	View		2 chunks	+14 lines, -16 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages