Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 697473006: Properly handle stack overflows in the AST graph builder. (Closed)

Created:
6 years, 1 month ago by Michael Starzinger
Modified:
6 years, 1 month ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Properly handle stack overflows in the AST graph builder. R=jarin@chromium.org BUG=chromium:429159 TEST=mjsunit/regress/regress-crbug-429159 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=25037

Patch Set 1 #

Patch Set 2 : Harden test case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -4 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +19 lines, -3 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-429159.js View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 1 month ago (2014-10-31 13:22:10 UTC) #1
Jarin
lgtm
6 years, 1 month ago (2014-10-31 13:55:08 UTC) #2
Michael Starzinger
6 years, 1 month ago (2014-10-31 14:02:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 25037 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698