Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: src/compiler/pipeline.cc

Issue 697473006: Properly handle stack overflows in the AST graph builder. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Harden test case. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | test/mjsunit/regress/regress-crbug-429159.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/pipeline.h" 5 #include "src/compiler/pipeline.h"
6 6
7 #include <fstream> // NOLINT(readability/streams) 7 #include <fstream> // NOLINT(readability/streams)
8 #include <sstream> 8 #include <sstream>
9 9
10 #include "src/base/platform/elapsed-timer.h" 10 #include "src/base/platform/elapsed-timer.h"
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 PipelineData data(info(), &zone_pool, pipeline_statistics.get()); 312 PipelineData data(info(), &zone_pool, pipeline_statistics.get());
313 313
314 data.source_positions()->AddDecorator(); 314 data.source_positions()->AddDecorator();
315 315
316 Node* context_node; 316 Node* context_node;
317 { 317 {
318 PhaseScope phase_scope(pipeline_statistics.get(), "graph builder"); 318 PhaseScope phase_scope(pipeline_statistics.get(), "graph builder");
319 ZonePool::Scope zone_scope(data.zone_pool()); 319 ZonePool::Scope zone_scope(data.zone_pool());
320 AstGraphBuilderWithPositions graph_builder( 320 AstGraphBuilderWithPositions graph_builder(
321 zone_scope.zone(), info(), data.jsgraph(), data.source_positions()); 321 zone_scope.zone(), info(), data.jsgraph(), data.source_positions());
322 graph_builder.CreateGraph(); 322 if (!graph_builder.CreateGraph()) return Handle<Code>::null();
323 context_node = graph_builder.GetFunctionContext(); 323 context_node = graph_builder.GetFunctionContext();
324 } 324 }
325 325
326 VerifyAndPrintGraph(data.graph(), "Initial untyped", true); 326 VerifyAndPrintGraph(data.graph(), "Initial untyped", true);
327 327
328 { 328 {
329 PhaseScope phase_scope(pipeline_statistics.get(), 329 PhaseScope phase_scope(pipeline_statistics.get(),
330 "early control reduction"); 330 "early control reduction");
331 SourcePositionTable::Scope pos(data.source_positions(), 331 SourcePositionTable::Scope pos(data.source_positions(),
332 SourcePosition::Unknown()); 332 SourcePosition::Unknown());
(...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after
627 } 627 }
628 628
629 629
630 void Pipeline::TearDown() { 630 void Pipeline::TearDown() {
631 InstructionOperand::TearDownCaches(); 631 InstructionOperand::TearDownCaches();
632 } 632 }
633 633
634 } // namespace compiler 634 } // namespace compiler
635 } // namespace internal 635 } // namespace internal
636 } // namespace v8 636 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | test/mjsunit/regress/regress-crbug-429159.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698