Issue 6973073: Avoid canceling a pending navigation if the old RVH commits right away.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6973073: Avoid canceling a pending navigation if the old RVH commits right away. (Closed)

Created:
9 years, 6 months ago by Charlie Reis

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews, joi+watch-content_chromium.org, Avi (use Gerrit), brettw-cc_chromium.org, jam, Paweł Hajdan Jr., Mark Mentovai

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Avoid canceling a pending navigation if the old RVH commits right away. BUG=79176 TEST=TabContentsTest.CrossSiteNotPreemptedDuringBeforeUnload Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87617

Patch Set 1 #

Patch Set 2 : Fix failing unit tests. #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -82 lines)			Patch
M	chrome/browser/tab_contents/web_contents_unittest.cc	View		1 chunk	+24 lines, -24 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host.cc	View		1 chunk	+8 lines, -16 lines	1 comment	Download
M	content/browser/tab_contents/navigation_controller_unittest.cc	View	1	13 chunks	+44 lines, -40 lines	0 comments	Download
M	content/browser/tab_contents/render_view_host_manager_unittest.cc	View	1	1 chunk	+7 lines, -1 line	0 comments	Download
M	content/browser/tab_contents/test_tab_contents.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

The try jobs revealed several unit tests that needed updating. Before, we could ignore the ...

9 years, 6 months ago (2011-06-01 23:44:49 UTC) #2

brettw

9 years, 6 months ago (2011-06-02 08:48:24 UTC) #3

LGTM

http://codereview.chromium.org/6973073/diff/3001/content/browser/renderer_hos...
File content/browser/renderer_host/render_view_host.cc (right):

http://codereview.chromium.org/6973073/diff/3001/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host.cc:807: // to allow the pending
navigation to continue.
This explanation seems reasonable, but I'm trusting you that this is the right
thing :)

Expand Messages | Collapse Messages