content/browser/tab_contents/test_tab_contents.cc - Issue 6973073: Avoid canceling a pending navigation if the old RVH commits right away.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tab_contents/test_tab_contents.cc

Issue 6973073: Avoid canceling a pending navigation if the old RVH commits right away. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix failing unit tests. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/tab_contents/test_tab_contents.cc

diff --git a/content/browser/tab_contents/test_tab_contents.cc b/content/browser/tab_contents/test_tab_contents.cc

index 396e2e68fbf366736a0314e27c5051e458d8f7ed..d541a9ec4dc1e05790f2622793138195bd54eb2c 100644

--- a/content/browser/tab_contents/test_tab_contents.cc

+++ b/content/browser/tab_contents/test_tab_contents.cc

@@ -78,5 +78,7 @@ void TestTabContents::CommitPendingNavigation() {

void TestTabContents::ProceedWithCrossSiteNavigation() {

if (!pending_rvh())

return;

- render_manager_.ShouldClosePage(true, true);

+ TestRenderViewHost* rvh = static_cast<TestRenderViewHost*>(

+ render_manager_.current_host());

+ rvh->SendShouldCloseACK(true);

}