chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc - Issue 697223003: MacViews: Get chrome/browser/ui/views/frame to compile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc

Issue 697223003: MacViews: Get chrome/browser/ui/views/frame to compile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@constrained

Patch Set: Rebase. Add mac_views_browser build flag Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc ('K') | « chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc

diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc b/chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc

index 7edd1401fa795e9404e6faa6b84e72286540b7fd..99549a4cbae5fdaf5b03e078257d2281d4831f12 100644

--- a/chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc

+++ b/chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc

@@ -4,14 +4,19 @@

#include "chrome/browser/ui/host_desktop.h"

#include "chrome/browser/ui/views/frame/immersive_mode_controller_stub.h"

+#if defined(USE_ASH)

tapted 2014/11/04 02:33:43 I'd go for a separate file: immersive_mode_control

Andre 2014/11/05 02:04:23 Done.

#include "chrome/browser/ui/views/frame/immersive_mode_controller_ash.h"

+#endif

namespace chrome {

ImmersiveModeController* CreateImmersiveModeController(

chrome::HostDesktopType host_desktop_type) {

+#if defined(USE_ASH)

if (host_desktop_type == chrome::HOST_DESKTOP_TYPE_ASH)

return new ImmersiveModeControllerAsh();

+#endif

return new ImmersiveModeControllerStub();

}