chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc - Issue 697223003: MacViews: Get chrome/browser/ui/views/frame to compile

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc

Issue 697223003: MacViews: Get chrome/browser/ui/views/frame to compile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@constrained

Patch Set: Rebase. Add mac_views_browser build flag Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc ('K') | « chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/host_desktop.h"	5 #include "chrome/browser/ui/host_desktop.h"

6 #include "chrome/browser/ui/views/frame/immersive_mode_controller_stub.h"	6 #include "chrome/browser/ui/views/frame/immersive_mode_controller_stub.h"

	7

	8 #if defined(USE_ASH)
	tapted 2014/11/04 02:33:43 I'd go for a separate file: immersive_mode_control I'd go for a separate file: immersive_mode_controller_factory_mac.cc which returns a `new ImmersiveModeControllerStub();` unconditionally, and just exclude this file from a mac build (or give it an _ash suffix if that works for gn) Andre 2014/11/05 02:04:23 Done. Show quoted text On 2014/11/04 02:33:43, tapted wrote: > I'd go for a separate file: immersive_mode_controller_factory_mac.cc which > returns a `new ImmersiveModeControllerStub();` unconditionally, and just exclude > this file from a mac build (or give it an _ash suffix if that works for gn) Done.
7 #include "chrome/browser/ui/views/frame/immersive_mode_controller_ash.h"	9 #include "chrome/browser/ui/views/frame/immersive_mode_controller_ash.h"

	10 #endif

8	11

9 namespace chrome {	12 namespace chrome {

10	13

11 ImmersiveModeController* CreateImmersiveModeController(	14 ImmersiveModeController* CreateImmersiveModeController(

12 chrome::HostDesktopType host_desktop_type) {	15 chrome::HostDesktopType host_desktop_type) {

	16 #if defined(USE_ASH)

13 if (host_desktop_type == chrome::HOST_DESKTOP_TYPE_ASH)	17 if (host_desktop_type == chrome::HOST_DESKTOP_TYPE_ASH)

14 return new ImmersiveModeControllerAsh();	18 return new ImmersiveModeControllerAsh();

	19 #endif

15	20

16 return new ImmersiveModeControllerStub();	21 return new ImmersiveModeControllerStub();

17 }	22 }

18	23

19 } // namespace chrome	24 } // namespace chrome

OLD	NEW