Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller.h

Issue 697223003: MacViews: Get chrome/browser/ui/views/frame to compile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@constrained
Patch Set: Rebase. Add mac_views_browser build flag Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/immersive_mode_controller.h
diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller.h b/chrome/browser/ui/views/frame/immersive_mode_controller.h
index 6f24dddf14fd7c045ac1028e82382f149d8f3541..82462eb9b98be36b1f6e8fdbf67dfefec76df97a 100644
--- a/chrome/browser/ui/views/frame/immersive_mode_controller.h
+++ b/chrome/browser/ui/views/frame/immersive_mode_controller.h
@@ -5,7 +5,6 @@
#ifndef CHROME_BROWSER_UI_VIEWS_FRAME_IMMERSIVE_MODE_CONTROLLER_H_
#define CHROME_BROWSER_UI_VIEWS_FRAME_IMMERSIVE_MODE_CONTROLLER_H_
-#include "ash/wm/immersive_revealed_lock.h"
#include "base/compiler_specific.h"
#include "base/observer_list.h"
#include "chrome/browser/ui/host_desktop.h"
@@ -17,7 +16,19 @@ class Rect;
class Size;
}
-typedef ash::ImmersiveRevealedLock ImmersiveRevealedLock;
+// A lock which will keep the top-of-window views revealed for its
+// lifetime.
+// See ImmersiveModeController::GetRevealedLock for details.
+class ImmersiveRevealedLock {
+ public:
+ virtual ~ImmersiveRevealedLock();
+
+ protected:
+ ImmersiveRevealedLock();
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(ImmersiveRevealedLock);
tapted 2014/11/04 02:33:43 I think you can turn this into a pure interface. W
Andre 2014/11/05 02:04:23 Done.
+};
// Controller for an "immersive mode" similar to MacOS presentation mode where
// the top-of-window views are hidden until the mouse hits the top of the
@@ -82,6 +93,7 @@ class ImmersiveModeController {
// If acquiring the lock causes a reveal, the top-of-window views will animate
// according to |animate_reveal|.
// The caller takes ownership of the returned lock.
+ // This is currently only supported on Ash.
virtual ImmersiveRevealedLock* GetRevealedLock(
tapted 2014/11/04 02:33:43 This should really be called `CreateRevealedLock`,
Andre 2014/11/05 02:04:23 I agree, but probably does not belong in this CL.
AnimateReveal animate_reveal) WARN_UNUSED_RESULT = 0;

Powered by Google App Engine
This is Rietveld 408576698