MacViews: Get chrome/browser/ui/views/frame to compile

chrome/browser/ui/views/frame/immersive_mode_controller.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_IMMERSIVE_MODE_CONTROLLER_H_
 #define CHROME_BROWSER_UI_VIEWS_FRAME_IMMERSIVE_MODE_CONTROLLER_H_
 
-#include "ash/wm/immersive_revealed_lock.h"
 #include "base/compiler_specific.h"
 #include "base/observer_list.h"
 #include "chrome/browser/ui/host_desktop.h"
 
 class BrowserView;
 
 namespace gfx {
 class Rect;
 class Size;
 }
 
-typedef ash::ImmersiveRevealedLock ImmersiveRevealedLock;
+// A lock which will keep the top-of-window views revealed for its
+// lifetime.
+// See ImmersiveModeController::GetRevealedLock for details.
+class ImmersiveRevealedLock {
+ public:
+  virtual ~ImmersiveRevealedLock();
+
+ protected:
+  ImmersiveRevealedLock();
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ImmersiveRevealedLock);

[tapted, 2014/11/04 02:33:43]

I think you can turn this into a pure interface. Which basically means removing
this line and inlining the definitions of the constructor/destructor.

[Andre, 2014/11/05 02:04:23]

Done.

+};
 
 // Controller for an "immersive mode" similar to MacOS presentation mode where
 // the top-of-window views are hidden until the mouse hits the top of the
 // screen. The tab strip is optionally painted with miniature "tab indicator"
 // rectangles.
 // Currently, immersive mode is only available for Chrome OS.
 class ImmersiveModeController {
  public:
   enum AnimateReveal {
     ANIMATE_REVEAL_YES,
@@ skipping 44 matching lines @@
   // Returns a lock which will keep the top-of-window views revealed for its
   // lifetime. Several locks can be obtained. When all of the locks are
   // destroyed, if immersive mode is enabled and there is nothing else keeping
   // the top-of-window views revealed, the top-of-window views will be closed.
   // This method always returns a valid lock regardless of whether immersive
   // mode is enabled. The lock's lifetime can span immersive mode being
   // enabled / disabled.
   // If acquiring the lock causes a reveal, the top-of-window views will animate
   // according to |animate_reveal|.
   // The caller takes ownership of the returned lock.
+  // This is currently only supported on Ash.
   virtual ImmersiveRevealedLock* GetRevealedLock(

[tapted, 2014/11/04 02:33:43]

This should really be called `CreateRevealedLock`, (and/or return a scoped_ptr,
but that's maybe unnecessary effort)

[Andre, 2014/11/05 02:04:23]

I agree, but probably does not belong in this CL.

       AnimateReveal animate_reveal) WARN_UNUSED_RESULT = 0;
 
   // Called by the find bar to indicate that its visible bounds have changed.
   // |new_visible_bounds_in_screen| should be empty if the find bar is not
   // visible.
   virtual void OnFindBarVisibleBoundsChanged(
       const gfx::Rect& new_visible_bounds_in_screen) = 0;
 
   // Disables animations and moves the mouse so that it is not over the
   // top-of-window views for the sake of testing. Must be called before
@@ skipping 12 matching lines @@
 
 namespace chrome {
 
 // Implemented in immersive_mode_controller_factory.cc.
 ImmersiveModeController* CreateImmersiveModeController(
     chrome::HostDesktopType host_desktop_type);
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_UI_VIEWS_FRAME_IMMERSIVE_MODE_CONTROLLER_H_