Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 697183003: Fix more Windows compile errors (Closed)

Created:
6 years, 1 month ago by scottmg
Modified:
6 years, 1 month ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Fix more Windows compile errors - Silence warnings in sky code (unnecessary return) - Disable some warnings for bison-generated code - Missing include for htons et al. - Don't build xdisplaycheck on Windows. R=jam@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fa2b293fe16a41f775d8875c636767a544161cfd

Patch Set 1 #

Patch Set 2 : remove NONCLIENTMETRICS_XP #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -29 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/win/win_util.h View 1 1 chunk +1 line, -21 lines 0 comments Download
M base/win/win_util.cc View 1 1 chunk +4 lines, -6 lines 0 comments Download
M sky/engine/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M sky/engine/core/dom/Node.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/wtf/ByteOrder.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
scottmg
6 years, 1 month ago (2014-11-04 00:38:41 UTC) #1
ojan
Is Windows a platform we're trying to support in the short-term?
6 years, 1 month ago (2014-11-04 01:04:15 UTC) #3
scottmg
On 2014/11/04 01:04:15, ojan wrote: > Is Windows a platform we're trying to support in ...
6 years, 1 month ago (2014-11-04 01:12:24 UTC) #4
jam
On 2014/11/04 01:04:15, ojan wrote: > Is Windows a platform we're trying to support in ...
6 years, 1 month ago (2014-11-04 01:29:51 UTC) #6
jam
lgtm
6 years, 1 month ago (2014-11-04 01:30:37 UTC) #7
scottmg
Committed patchset #2 (id:20001) manually as fa2b293fe16a41f775d8875c636767a544161cfd.
6 years, 1 month ago (2014-11-04 03:42:49 UTC) #8
abarth-chromium
6 years, 1 month ago (2014-11-04 03:53:06 UTC) #10
Message was sent while issue was closed.
I don't think Sky will link on Windows.  We removed all the hacks that used to
exist to make Windows work.

Powered by Google App Engine
This is Rietveld 408576698