Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1165)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sky/engine/BUILD.gn

Issue 697183003: Fix more Windows compile errors (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: remove NONCLIENTMETRICS_XP Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/win/win_util.cc ('k') | sky/engine/core/dom/Node.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/BUILD.gn
diff --git a/sky/engine/BUILD.gn b/sky/engine/BUILD.gn
index 120061999da1ed2782a88c1f927b3155ac3ce3be..4f8f0bec66464752ac2fb13b0310b8dd61cb5044 100644
--- a/sky/engine/BUILD.gn
+++ b/sky/engine/BUILD.gn
@@ -40,8 +40,11 @@ config("config") {
if (is_win) {
cflags += [
+ "/wd4065", # Switch statement contains 'default' but no 'case' labels.
+ # In generated parser code.
"/wd4305", # Truncation from 'type1' to 'type2'.
"/wd4324", # Struct padded due to declspec(align).
+ "/wd4702", # Unreachable code, happens in bison-generated code.
"/wd4714", # Function marked forceinline not inlined.
"/wd4800", # Value forced to bool.
"/wd4996", # Deprecated function call.
« no previous file with comments | « base/win/win_util.cc ('k') | sky/engine/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698