Issue 697163002: Devirtualize InterstitialPageImpl::CreateRenderViewHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 697163002: Devirtualize InterstitialPageImpl::CreateRenderViewHost (Closed)

Created:
6 years, 1 month ago by ncarter (slow)

Modified:
6 years, 1 month ago

Reviewers:
Charlie Reis

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Devirtualize InterstitialPageImpl::CreateRenderViewHost This isn't overridden by any tests, so make it a private method. BUG=304341 Committed: https://crrev.com/15136ee0f5d8c32f60c65e7e7e1cd0dd056f7d32 Cr-Commit-Position: refs/heads/master@{#302473}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	content/browser/frame_host/interstitial_page_impl.h	View		2 chunks	+3 lines, -4 lines	0 comments	Download
	M	content/browser/frame_host/interstitial_page_impl.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697163002/1

6 years, 1 month ago (2014-11-03 19:47:36 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-03 20:32:28 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/15136ee0f5d8c32f60c65e7e7e1cd0dd056f7d32
Cr-Commit-Position: refs/heads/master@{#302473}