Devirtualize InterstitialPageImpl::CreateRenderViewHost

content/browser/frame_host/interstitial_page_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_INTERSTITIAL_PAGE_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_INTERSTITIAL_PAGE_IMPL_H_
 
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
@@ skipping 150 matching lines @@
                               bool* is_keyboard_shortcut) override;
   void HandleKeyboardEvent(const NativeWebKeyboardEvent& event) override;
 #if defined(OS_WIN)
   virtual gfx::NativeViewAccessible GetParentNativeViewAccessible() override;
 #endif
 
   bool enabled() const { return enabled_; }
   WebContents* web_contents() const;
   const GURL& url() const { return url_; }
 
-  // Creates the RenderViewHost containing the interstitial content.
-  // Overriden in unit tests.
-  virtual RenderViewHost* CreateRenderViewHost();
-
   // Creates the WebContentsView that shows the interstitial RVH.
   // Overriden in unit tests.
   virtual WebContentsView* CreateWebContentsView();
 
   // Notification magic.
   NotificationRegistrar notification_registrar_;
 
  private:
   class InterstitialPageRVHDelegateView;
 
   // Disable the interstitial:
   // - if it is not yet showing, then it won't be shown.
   // - any command sent by the RenderViewHost will be ignored.
   void Disable();
 
   // Delete ourselves, causing Shutdown on the RVH to be called.
   void Shutdown();
 
   void OnNavigatingAwayOrTabClosing();
 
   // Executes the passed action on the ResourceDispatcher (on the IO thread).
   // Used to block/resume/cancel requests for the RenderViewHost hidden by this
   // interstitial.
   void TakeActionOnResourceDispatcher(ResourceRequestAction action);
 
   // IPC message handlers.
   void OnDomOperationResponse(const std::string& json_string,
                               int automation_id);
 
+  // Creates the RenderViewHost containing the interstitial content.
+  RenderViewHostImpl* CreateRenderViewHost();
+
   // The contents in which we are displayed.  This is valid until Hide is
   // called, at which point it will be set to NULL because the WebContents
   // itself may be deleted.
   WebContents* web_contents_;
 
   // The NavigationController for the content this page is being displayed over.
   NavigationControllerImpl* controller_;
 
   // Delegate for dispatching keyboard events and accessing the native view.
   RenderWidgetHostDelegate* render_widget_host_delegate_;
@@ skipping 66 matching lines @@
   scoped_refptr<SessionStorageNamespace> session_storage_namespace_;
 
   base::WeakPtrFactory<InterstitialPageImpl> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(InterstitialPageImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_INTERSTITIAL_PAGE_IMPL_H_