Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1647)

Issue 697143002: enable packed double precision 3 operand mem/simd register avx1 instructions. (Closed)

Created:
6 years, 1 month ago by shyamsundarr
Modified:
6 years, 1 month ago
Reviewers:
Karl
CC:
native-client-reviews_googlegroups.com
Project:
nacl
Visibility:
Public.

Description

enable packed double precision 3 operand mem/simd register avx1 instructions. All these instructions allow the forms: op src1=xmm src2=xmm/mem src3=xmm and op src1=ymm src2=ymm/mem src3=ymm The enabled instructions are: 'vaddpd', 'vaddsubpd', 'vandnpd', 'vandpd', 'vdivpd', 'vhaddpd', 'vhsubpd', 'vmaxpd', 'vminpd', 'vmulpd', 'vorpd', 'vsubpd', 'vunpckhpd', 'vunpcklpd', 'vxorpd' BUG=https://code.google.com/p/nativeclient/issues/detail?id=1972 R=kschimpf@google.com Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=14020

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9502 lines, -8323 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
A src/trusted/validator_ragel/avx1_xmm_ymm_memory_3op_pd_proof.py View 1 chunk +35 lines, -0 lines 0 comments Download
M src/trusted/validator_ragel/build.scons View 1 chunk +4 lines, -0 lines 0 comments Download
M src/trusted/validator_ragel/gen/protected_files.json View 1 chunk +4 lines, -4 lines 0 comments Download
M src/trusted/validator_ragel/gen/validator_x86_32.c View 23 chunks +164 lines, -156 lines 0 comments Download
M src/trusted/validator_ragel/gen/validator_x86_32.xml View 112 chunks +2036 lines, -1890 lines 0 comments Download
M src/trusted/validator_ragel/gen/validator_x86_64.xml View 680 chunks +7219 lines, -6242 lines 0 comments Download
M src/trusted/validator_ragel/instruction_definitions/xmm_instructions.def View 12 chunks +15 lines, -30 lines 0 comments Download
M src/trusted/validator_ragel/proof_tools_templates.py View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
shyamsundarr
6 years, 1 month ago (2014-11-03 18:30:20 UTC) #2
Karl
lgtm
6 years, 1 month ago (2014-11-03 18:59:28 UTC) #3
shyamsundarr
Committed patchset #1 (id:1) manually as 14020 (presubmit successful).
6 years, 1 month ago (2014-11-03 20:32:44 UTC) #4
shyamsundarr
6 years, 1 month ago (2014-11-03 22:49:14 UTC) #5
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698