Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 697053005: ignore /win/ files in presubmit for wstring (Closed)

Created:
6 years, 1 month ago by scottmg
Modified:
6 years, 1 month ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ignore /win/ files in presubmit for wstring R=cpu@chromium.org Committed: https://crrev.com/e6f0440932ca40307d7df95a7bd5721b5ef3be24 Cr-Commit-Position: refs/heads/master@{#302740}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M PRESUBMIT.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
scottmg
6 years, 1 month ago (2014-11-05 01:03:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697053005/1
6 years, 1 month ago (2014-11-05 01:07:32 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-05 01:07:33 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm
6 years, 1 month ago (2014-11-05 01:10:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697053005/1
6 years, 1 month ago (2014-11-05 01:13:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-05 02:00:05 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 02:00:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6f0440932ca40307d7df95a7bd5721b5ef3be24
Cr-Commit-Position: refs/heads/master@{#302740}

Powered by Google App Engine
This is Rietveld 408576698