PRESUBMIT.py - Issue 697053005: ignore /win/ files in presubmit for wstring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 697053005: ignore /win/ files in presubmit for wstring (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index ee872e269c047ec2b64fafdb93537f3d7bc0149f..3b39479546837f61a5219ecbaa4a6b29a1589256 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -361,7 +361,8 @@ def _CheckNoNewWStrings(input_api, output_api):

problems = []

for f in input_api.AffectedFiles():

if (not f.LocalPath().endswith(('.cc', '.h')) or

- f.LocalPath().endswith(('test.cc', '_win.cc', '_win.h'))):

+ f.LocalPath().endswith(('test.cc', '_win.cc', '_win.h')) or

+ '/win/' in f.LocalPath()):

continue

allowWString = False

« no previous file with comments | « no previous file | no next file » | no next file with comments »