Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 696953002: The name attribute can be from contents for listitem role(re-land) (Closed)

Created:
6 years, 1 month ago by je_julie(Not used)
Modified:
6 years, 1 month ago
Reviewers:
dmazzoni
CC:
blink-reviews, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/core/accessibility/AXNodeObject.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
je_julie(Not used)
Dominic, This patch makes litsItemRole have textUnderElement() for title. Before this patch is landed, TCs ...
6 years, 1 month ago (2014-11-02 16:17:21 UTC) #2
dmazzoni
lgtm
6 years, 1 month ago (2014-11-03 16:47:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696953002/1
6 years, 1 month ago (2014-11-03 16:48:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 184795
6 years, 1 month ago (2014-11-03 19:02:49 UTC) #6
Hajime Morrita
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/703473002/ by morrita@chromium.org. ...
6 years, 1 month ago (2014-11-03 21:52:34 UTC) #7
je_julie(Not used)
On 2014/11/03 21:52:34, morrita wrote: > A revert of this CL (patchset #1 id:1) has ...
6 years, 1 month ago (2014-11-04 02:52:38 UTC) #8
je_julie(Not used)
Hi Dominic, Chrome with this patch is same as working from FF. I checked Screen ...
6 years, 1 month ago (2014-11-08 14:29:51 UTC) #9
dmazzoni
lgtm
6 years, 1 month ago (2014-11-10 17:01:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696953002/1
6 years, 1 month ago (2014-11-11 02:37:01 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 02:37:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185092

Powered by Google App Engine
This is Rietveld 408576698