Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 696903002: Remove a lot of API surface from Element. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -197 lines) Patch
M sky/engine/core/dom/Element.h View 13 chunks +13 lines, -47 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 7 chunks +0 lines, -85 lines 0 comments Download
M sky/engine/core/dom/Node.h View 4 chunks +3 lines, -10 lines 0 comments Download
M sky/engine/core/dom/shadow/ElementShadow.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/shadow/ElementShadow.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/dom/shadow/SelectRuleFeatureSet.h View 1 chunk +0 lines, -12 lines 0 comments Download
M sky/engine/core/dom/shadow/SelectRuleFeatureSet.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/frame/UseCounter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/html/HTMLElement.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/html/HTMLElement.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M sky/engine/core/html/parser/HTMLConstructionSite.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/public/web/WebElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ojan
lgtm
6 years, 1 month ago (2014-10-31 23:47:56 UTC) #1
esprehn
6 years, 1 month ago (2014-10-31 23:48:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bedeb08aa35e5fbf39cee496c2729481548f7a39.

Powered by Google App Engine
This is Rietveld 408576698