Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: sky/engine/core/dom/Node.h

Issue 696903002: Remove a lot of API surface from Element. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/Element.cpp ('k') | sky/engine/core/dom/shadow/ElementShadow.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/Node.h
diff --git a/sky/engine/core/dom/Node.h b/sky/engine/core/dom/Node.h
index cd948d00a0746d30cb90c256876c3f06bd3bff1b..a642dd3ee8db6d72f0c6695ae56e646866664241 100644
--- a/sky/engine/core/dom/Node.h
+++ b/sky/engine/core/dom/Node.h
@@ -572,8 +572,6 @@ public:
void setAlreadySpellChecked(bool flag) { setFlag(flag, AlreadySpellCheckedFlag); }
bool isAlreadySpellChecked() { return getFlag(AlreadySpellCheckedFlag); }
- bool isFinishedParsingChildren() const { return getFlag(IsFinishedParsingChildrenFlag); }
-
virtual void trace(Visitor*) override;
unsigned lengthOfContents() const;
@@ -605,12 +603,9 @@ private:
InDocumentFlag = 1 << 10,
IsInShadowTreeFlag = 1 << 11,
- // Set by the parser when the children are done parsing.
- IsFinishedParsingChildrenFlag = 1 << 12,
-
// Flags related to recalcStyle.
- // FIXME(sky): Flag 13 is free.
+ // FIXME(sky): Flags 12 and 13 are free.
HasCustomStyleCallbacksFlag = 1 << 14,
ChildNeedsStyleInvalidationFlag = 1 << 15,
@@ -628,10 +623,10 @@ private:
HasEventTargetDataFlag = 1 << 26,
AlreadySpellCheckedFlag = 1 << 27,
- DefaultNodeFlags = IsFinishedParsingChildrenFlag | ChildNeedsStyleRecalcFlag | NeedsReattachStyleChange
+ DefaultNodeFlags = ChildNeedsStyleRecalcFlag | NeedsReattachStyleChange
};
- // 5 bits remaining.
+ // 6 bits remaining.
bool getFlag(NodeFlags mask) const { return m_nodeFlags & mask; }
void setFlag(bool f, NodeFlags mask) { m_nodeFlags = (m_nodeFlags & ~mask) | (-(int32_t)f & mask); }
@@ -683,8 +678,6 @@ protected:
void markAncestorsWithChildNeedsStyleRecalc();
- void setIsFinishedParsingChildren(bool value) { setFlag(value, IsFinishedParsingChildrenFlag); }
-
private:
friend class TreeShared<Node>;
friend class WeakNodeMap;
« no previous file with comments | « sky/engine/core/dom/Element.cpp ('k') | sky/engine/core/dom/shadow/ElementShadow.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698