Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1704)

Unified Diff: Source/core/rendering/RenderReplaced.cpp

Issue 696703005: Remove RenderSelectionInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebaselined change. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderReplaced.cpp
diff --git a/Source/core/rendering/RenderReplaced.cpp b/Source/core/rendering/RenderReplaced.cpp
index a6435765cf09c474db19cf39ec6e875102616e64..ceb4093a214a4b7e706790278096f3e2a60261d8 100644
--- a/Source/core/rendering/RenderReplaced.cpp
+++ b/Source/core/rendering/RenderReplaced.cpp
@@ -437,6 +437,9 @@ LayoutRect RenderReplaced::selectionRectForPaintInvalidation(const RenderLayerMo
LayoutRect rect = localSelectionRect();
mapRectToPaintInvalidationBacking(paintInvalidationContainer, rect, 0);
+ // FIXME: groupedMapping() leaks the squashing abstraction.
leviw_travelin_and_unemployed 2014/11/12 23:41:43 *sigh*... this continually makes me sad.
chrishtr 2014/11/13 00:22:36 I think you should be able to just call RenderLaye
Julien - ping for review 2014/11/13 01:09:32 This change is a refactoring so it should just mov
+ if (paintInvalidationContainer->layer()->groupedMapping())
+ RenderLayer::mapRectToPaintBackingCoordinates(paintInvalidationContainer, rect);
return rect;
}

Powered by Google App Engine
This is Rietveld 408576698