Remove RenderSelectionInfo

Source/core/rendering/RenderReplaced.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2006, 2007 Apple Inc. All rights reserved.
  * Copyright (C) Research In Motion Limited 2011-2012. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 419 matching lines @@
 
 LayoutRect RenderReplaced::selectionRectForPaintInvalidation(const RenderLayerModelObject* paintInvalidationContainer) const
 {
     ASSERT(!needsLayout());
 
     if (!isSelected())
         return LayoutRect();
 
     LayoutRect rect = localSelectionRect();
     mapRectToPaintInvalidationBacking(paintInvalidationContainer, rect, 0);
+    // FIXME: groupedMapping() leaks the squashing abstraction.

[leviw_travelin_and_unemployed, 2014/11/12 23:41:43]

*sigh*... this continually makes me sad.

[chrishtr, 2014/11/13 00:22:36]

I think you should be able to just call
RenderLayer::mapRectToPaintInvalidationBacking and not leak groupedMapping().

I meant to try this in the old selection code and never got around to it.

[Julien - ping for review, 2014/11/13 01:09:32]

This change is a refactoring so it should just move code around, not fix some
existing bug. I am happy to follow-up on that!

+    if (paintInvalidationContainer->layer()->groupedMapping())
+        RenderLayer::mapRectToPaintBackingCoordinates(paintInvalidationContainer, rect);
     return rect;
 }
 
 LayoutRect RenderReplaced::localSelectionRect(bool checkWhetherSelected) const
 {
     if (checkWhetherSelected && !isSelected())
         return LayoutRect();
 
     if (!inlineBoxWrapper())
         // We're a block-level replaced element.  Just return our own dimensions.
@@ skipping 51 matching lines @@
         return LayoutRect();
 
     // The selectionRect can project outside of the overflowRect, so take their union
     // for paint invalidation to avoid selection painting glitches.
     LayoutRect r = isSelected() ? localSelectionRect() : visualOverflowRect();
     mapRectToPaintInvalidationBacking(paintInvalidationContainer, r, paintInvalidationState);
     return r;
 }
 
 }