Source/core/rendering/RenderMultiColumnFlowThread.cpp - Issue 696523003: [New Multicolumn] Use the return value from flipForWritingMode().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMultiColumnFlowThread.cpp

Issue 696523003: [New Multicolumn] Use the return value from flipForWritingMode(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase master Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderMultiColumnFlowThread.cpp

diff --git a/Source/core/rendering/RenderMultiColumnFlowThread.cpp b/Source/core/rendering/RenderMultiColumnFlowThread.cpp

index 3bacd490d4ec1a851be613a0f9ec31f375ca95dc..a6bd077631340a6ab76f66050846204bb21e013f 100644

--- a/Source/core/rendering/RenderMultiColumnFlowThread.cpp

+++ b/Source/core/rendering/RenderMultiColumnFlowThread.cpp

@@ -128,8 +128,7 @@ LayoutSize RenderMultiColumnFlowThread::columnOffset(const LayoutPoint& point) c

if (!hasValidRegionInfo())

return LayoutSize(0, 0);

- LayoutPoint flowThreadPoint(point);

- flipForWritingMode(flowThreadPoint);

+ LayoutPoint flowThreadPoint = flipForWritingMode(point);

LayoutUnit blockOffset = isHorizontalWritingMode() ? flowThreadPoint.y() : flowThreadPoint.x();

RenderMultiColumnSet* columnSet = columnSetAtBlockOffset(blockOffset);

if (!columnSet)

« no previous file with comments | « Source/core/rendering/RenderBox.h ('k') | no next file » | no next file with comments »