Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Unified Diff: Source/core/rendering/RenderBox.h

Issue 696523003: [New Multicolumn] Use the return value from flipForWritingMode(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase master Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/core/rendering/RenderMultiColumnFlowThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderBox.h
diff --git a/Source/core/rendering/RenderBox.h b/Source/core/rendering/RenderBox.h
index 53309c36303d01cb525d2352fdc4fd81bb03d6f8..5a899c0b52e8d3b42b418f3e092217a3bf722d12 100644
--- a/Source/core/rendering/RenderBox.h
+++ b/Source/core/rendering/RenderBox.h
@@ -537,21 +537,21 @@ public:
virtual LayoutUnit offsetTop() const override;
LayoutPoint flipForWritingModeForChild(const RenderBox* child, const LayoutPoint&) const;
- LayoutUnit flipForWritingMode(LayoutUnit position) const
+ LayoutUnit flipForWritingMode(LayoutUnit position) const WARN_UNUSED_RETURN
{
// The offset is in the block direction (y for horizontal writing modes, x for vertical writing modes).
if (!UNLIKELY(hasFlippedBlocksWritingMode()))
return position;
return logicalHeight() - position;
}
- LayoutPoint flipForWritingMode(const LayoutPoint& position) const
+ LayoutPoint flipForWritingMode(const LayoutPoint& position) const WARN_UNUSED_RETURN
{
if (!UNLIKELY(hasFlippedBlocksWritingMode()))
return position;
return isHorizontalWritingMode() ? LayoutPoint(position.x(), height() - position.y()) : LayoutPoint(width() - position.x(), position.y());
}
LayoutPoint flipForWritingModeIncludingColumns(const LayoutPoint&) const;
- LayoutSize flipForWritingMode(const LayoutSize& offset) const
+ LayoutSize flipForWritingMode(const LayoutSize& offset) const WARN_UNUSED_RETURN
{
if (!UNLIKELY(hasFlippedBlocksWritingMode()))
return offset;
@@ -566,7 +566,7 @@ public:
else
rect.setX(width() - rect.maxX());
}
- FloatPoint flipForWritingMode(const FloatPoint& position) const
+ FloatPoint flipForWritingMode(const FloatPoint& position) const WARN_UNUSED_RETURN
{
if (!UNLIKELY(hasFlippedBlocksWritingMode()))
return position;
« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/core/rendering/RenderMultiColumnFlowThread.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698