[New Multicolumn] Use the return value from flipForWritingMode().

[New Multicolumn] Use the return value from flipForWritingMode().

flipForWritingMode() comes in at least two flavors; one that takes a
LayoutRect& and one that takes a LayoutSize&. The one that takes
LayoutRect puts the result in the reference passed (and returns nothing).
The one that takes LayoutSize leaves the reference passed untouched
(after all, it's const) and returns the result. Not confusing at all.

Better not ignore the returned value when using the LayoutSize version.

This fixes fast/multicol/vertical-rl/composited-relpos-overlapping-will-change.html

BUG=359877
R=jchaffraix@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184757

[mstensho (USE GERRIT), 2014-10-30 22:16:03]

This makes the vertical-rl test added in
https://codereview.chromium.org/655003005/ pass.

[Julien - ping for review, 2014-10-31 17:56:37]

lgtm

This patch should mark the confusing flipForWritingMode with WARN_UNUSED_RETURN.

[mstensho (USE GERRIT), 2014-10-31 21:46:35]

On 2014/10/31 17:56:37, Julien Chaffraix - PST wrote:
> lgtm
> 
> This patch should mark the confusing flipForWritingMode with
WARN_UNUSED_RETURN.

Did it for all flipForWritingMode() methods that return something. There were 4.

[mstensho (USE GERRIT), 2014-10-31 21:46:38]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2014-10-31 21:47:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/696523003/20001

[commit-bot: I haz the power, 2014-10-31 21:47:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-31 21:47:38]

Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 1030.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
baeb829373afedd3cd6c9a95e63717e3c9f27c06..ac9604c3d610056ed3cafda8394710ffcd2b2707
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -1030,7 +1030,6 @@ crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-lr/unsplitta
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-rl/border-padding-pagination.html
[ Skip ]
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-rl/break-properties.html [
Skip ]
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-rl/column-rules.html [ Skip ]
-crbug.com/359877
virtual/regionbasedmulticol/fast/multicol/vertical-rl/composited-relpos-overlapping-will-change.html
[ ImageOnlyFailure ]
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-rl/float-paginate-complex.html
[ Skip ]
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-rl/float-paginate.html [ Skip
]
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-rl/float-truncation.html [
Skip ]

[mstensho (USE GERRIT), 2014-10-31 21:53:15]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2014-10-31 21:54:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/696523003/40001

[commit-bot: I haz the power, 2014-10-31 23:12:41]

Committed patchset #3 (id:40001) as 184757