Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 696493004: Expand viewport trigger for GPU rasterization (Closed)

Created:
6 years, 1 month ago by ajuma
Modified:
6 years, 1 month ago
CC:
blink-reviews, junchao.han, Vangelis Kokkevis
Project:
blink
Visibility:
Public.

Description

Expand viewport trigger for GPU rasterization This expands the viewport trigger for GPU rasterization to all viewport tags containing "width=device-width". This is a generalization of the current trigger (which additionally requires "minimum-scale=1"). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185058

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -16 lines) Patch
M Source/web/WebViewImpl.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/web/tests/ViewportTest.cpp View 1 1 chunk +8 lines, -8 lines 0 comments Download
D Source/web/tests/data/viewport/viewport-inferred-values-do-not-trigger-gpu-rasterization.html View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
ajuma
6 years, 1 month ago (2014-10-30 23:11:21 UTC) #2
ernstm
On 2014/10/30 23:11:21, ajuma wrote: LGTM
6 years, 1 month ago (2014-10-31 00:24:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696493004/1
6 years, 1 month ago (2014-10-31 00:32:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/18777)
6 years, 1 month ago (2014-10-31 00:37:25 UTC) #7
ajuma
+aelias for Source/web OWNERS
6 years, 1 month ago (2014-10-31 01:16:49 UTC) #9
aelias_OOO_until_Jul13
Could we hold this off until after M40 branch point (which is just a week ...
6 years, 1 month ago (2014-10-31 01:37:02 UTC) #10
ernstm
On 2014/10/31 01:37:02, aelias wrote: > Could we hold this off until after M40 branch ...
6 years, 1 month ago (2014-10-31 19:42:11 UTC) #11
ajuma
On 2014/10/31 19:42:11, ernstm wrote: > On 2014/10/31 01:37:02, aelias wrote: > > Could we ...
6 years, 1 month ago (2014-11-10 18:33:11 UTC) #12
aelias_OOO_until_Jul13
OK, lgtm.
6 years, 1 month ago (2014-11-10 19:14:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696493004/20001
6 years, 1 month ago (2014-11-10 19:27:22 UTC) #15
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 19:52:39 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185058

Powered by Google App Engine
This is Rietveld 408576698