Source/web/tests/ViewportTest.cpp - Issue 696493004: Expand viewport trigger for GPU rasterization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/ViewportTest.cpp

Issue 696493004: Expand viewport trigger for GPU rasterization (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/web/WebViewImpl.cpp ('k') | Source/web/tests/data/viewport/viewport-inferred-values-do-not-trigger-gpu-rasterization.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/tests/ViewportTest.cpp

diff --git a/Source/web/tests/ViewportTest.cpp b/Source/web/tests/ViewportTest.cpp

index c7ff109f808133885bceafc13fdeb5c3da1db235..b2d8680ad6434ee0f9f6eb1b49b96002bb34af82 100644

--- a/Source/web/tests/ViewportTest.cpp

+++ b/Source/web/tests/ViewportTest.cpp

@@ -2947,23 +2947,23 @@ TEST_F(ViewportTest, viewportTriggersGpuRasterization)

webViewHelper.webView()->resize(WebSize(640, 480));

EXPECT_TRUE(webViewHelper.webViewImpl()->matchesHeuristicsForGpuRasterizationForTesting());

- registerMockedHttpURLLoad("viewport/viewport-inferred-values-do-not-trigger-gpu-rasterization.html");

- webViewHelper.initializeAndLoad(m_baseURL + "viewport/viewport-inferred-values-do-not-trigger-gpu-rasterization.html", true, 0, 0, setViewportSettings);

- webViewHelper.webView()->resize(WebSize(640, 480));

- EXPECT_FALSE(webViewHelper.webViewImpl()->matchesHeuristicsForGpuRasterizationForTesting());

registerMockedHttpURLLoad("viewport/viewport-1.html");

webViewHelper.initializeAndLoad(m_baseURL + "viewport/viewport-1.html", true, 0, 0, setViewportSettings);

webViewHelper.webView()->resize(WebSize(640, 480));

- EXPECT_FALSE(webViewHelper.webViewImpl()->matchesHeuristicsForGpuRasterizationForTesting());

+ EXPECT_TRUE(webViewHelper.webViewImpl()->matchesHeuristicsForGpuRasterizationForTesting());

registerMockedHttpURLLoad("viewport/viewport-15.html");

webViewHelper.initializeAndLoad(m_baseURL + "viewport/viewport-15.html", true, 0, 0, setViewportSettings);

webViewHelper.webView()->resize(WebSize(640, 480));

EXPECT_FALSE(webViewHelper.webViewImpl()->matchesHeuristicsForGpuRasterizationForTesting());

- registerMockedHttpURLLoad("viewport/viewport-130.html");

- webViewHelper.initializeAndLoad(m_baseURL + "viewport/viewport-130.html", true, 0, 0, setViewportSettings);

+ registerMockedHttpURLLoad("no_viewport_tag.html");

+ webViewHelper.initializeAndLoad(m_baseURL + "no_viewport_tag.html", true, 0, 0, setViewportSettings);

+ webViewHelper.webView()->resize(WebSize(640, 480));

+ EXPECT_FALSE(webViewHelper.webViewImpl()->matchesHeuristicsForGpuRasterizationForTesting());

+ registerMockedHttpURLLoad("200-by-300-viewport.html");

+ webViewHelper.initializeAndLoad(m_baseURL + "200-by-300-viewport.html", true, 0, 0, setViewportSettings);

webViewHelper.webView()->resize(WebSize(640, 480));

EXPECT_FALSE(webViewHelper.webViewImpl()->matchesHeuristicsForGpuRasterizationForTesting());

}